Upgrade browser/accessibility tests for Puppeteer v18 #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching away from the deprecated `axe-puppeteer` in future unblocks `puppeteer` upgrades: ``` npm ERR! Could not resolve dependency: npm ERR! peer puppeteer@">=1.10.0 <= 18" from @axe-core/puppeteer@4.5.2 ```
Additionally adds `jest-axe` for violation reporting
Recent axe update can’t use `puppeteer@19` yet ``` npm ERR! Could not resolve dependency: npm ERR! peer puppeteer@">=1.10.0 <= 18" from @axe-core/puppeteer@4.5.2 ```
This matches axe behaviour from previous releases, but see discussion: #2442 (comment)
Includes various changes and fixes for the `puppeteer@18` upgrade
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Note: We've had to hold off npm ERR! Could not resolve dependency:
npm ERR! peer puppeteer@">=1.10.0 <= 18" from @axe-core/puppeteer@4.5.2 |
colinrotherham
commented
Jan 13, 2023
| }, | ||
| globals: { | ||
| page: true, | ||
| browser: true |
There was a problem hiding this comment.
Allows the jest-puppeteer page and browser globals to work without lint errors
colinrotherham
commented
Jan 13, 2023
colinrotherham
commented
Jan 13, 2023
colinrotherham
commented
Jan 13, 2023
colinrotherham
commented
Jan 13, 2023
Includes CLI flags for colour output, GitHub Actions reporter, ESLint config changes for test globals
4bff55b to
ea4ec2b
Compare
domoscargin
reviewed
Jan 16, 2023
domoscargin
approved these changes
Jan 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fairly drastic bump to
puppeteer@1.14.0puppeteer@18.2.1Which includes:
govuk-frontend./lib/puppeteer-helpers.js@axe-core/puppeteerto replaceaxe-puppeteerincognitocontextLots of tests have been simplified to the newer Puppeteer selector methods:
Plus various other anti-flakiness improvements inspired by:
Closes #2468