Bump axe-puppeteer from 1.0.0 to 1.1.1 #2442
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Glanced at this yesterday. I think we have errors caused by:
Both of those are easily fixed by excluding Then there's a bunch of errors on the component page test (radios) which I think are caused by some kind of iFrame mix up. For example, the second code sample has an I would've expected main page content and iFrame content to be dealt with separately in terms of WCAG rules, but I haven't dug in enough to figure out if that's the case and this is some kind of bug with our code, or if this is correct behaviour. Maybe @davidc-gds knows more? |
|
Hey @domoscargin I did a bit of testing today with NVDA and JAWS, and they do pick up headings within iframes. They also don't differentiate between headings in an iframe and outside of an iframe -- they're all lumped together in the list of headings. This does mean that a legit issue is being picked up, and it's not really a bug. That being said, I don't see how we could fix it, since it's important that we use <h1> headings in these examples. Might just need to be one of those things we ignore / acknowledge in our pages that have examples. |
|
[Extra trivia] I found this blog post that talks a bit about heading levels across iframes and how screen readers interact with that. My previous comment covers this stuff, but it's a fairly informative article for those interested. https://www.accessibility-developer-guide.com/examples/headings/iframes/ |
cc478fc to
abc07d9
Compare
Bumps [axe-puppeteer](https://github.com/dequelabs/axe-puppeteer) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/dequelabs/axe-puppeteer/releases) - [Changelog](https://github.com/dequelabs/axe-puppeteer/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-puppeteer/commits) --- updated-dependencies: - dependency-name: axe-puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d3bad66 to
69e3648
Compare
There was a problem hiding this comment.
Huh, the iFrame issues seem to have sorted themselves. Suspect it may have to do with changes to the markdown which has cleaned up our compiled output a bit.
I've added fixes for the skip link and back to top buttons, both of which were being flagged as not contained in a landmark, and both of which are intentionally so.
|
Ah, no - the iFrame issues come when switching from the deprecated |
This matches axe behaviour from previous releases, but see discussion: #2442 (comment)
This matches axe behaviour from previous releases, but see discussion: #2442 (comment)
Bumps axe-puppeteer from 1.0.0 to 1.1.1.
Changelog
Sourced from axe-puppeteer's changelog.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)