Actions menu in Subspace List * #6885
Conversation
WalkthroughThe changes introduced in the pull request involve a substantial refactor of components related to managing challenges, transitioning to a focus on subspaces. Key modifications include renaming components, updating GraphQL queries and mutations, and enhancing user interface elements to better support subspace management. New functionalities such as duplicating and saving subspaces as templates have been added, along with improved data structures and user interactions, including confirmation dialogs for deletions. Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (4)
src/domain/community/contributor/organization/adminOrganizations/LicensePlanDialog.tsx (1)
1-58: LGTM! TheLicensePlanDialogcomponent is well-structured and enhances the license plan management functionality.The component follows best practices by:
- Utilizing Material-UI components for a consistent and visually appealing dialog.
- Leveraging the
useTranslationhook for internationalization.- Conditionally rendering the
PlansTableandAssignPlancomponents based on the availability oflicensePlans.- Effectively managing the state and behavior of the dialog through the provided props.
Here are a few suggestions for further improvement:
- Consider adding prop types validation using the
PropTypespackage to ensure that the required props are provided and have the correct types.- If the
PlansTableandAssignPlancomponents are specific to theLicensePlanDialog, consider moving them into the same file to keep the related components together.- Add inline comments to explain any complex logic or non-obvious parts of the code to improve maintainability.
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (1)
74-74: LGTM, but consider the visual impact.The changes look good:
- The
sizeprop is correctly passed to theJourneyAvatarcomponent, allowing for flexible rendering.However, please consider the visual impact of setting the
borderRadiusto 'unset' in themergedSxobject. This may affect the overall styling of the card.Also applies to: 81-81
src/domain/platform/admin/components/SearchableTable.tsx (1)
1-150: LGTM! TheSearchableTablecomponent is well-designed and implemented.The component is modular, reusable, and maintainable. It provides a user-friendly interface for displaying and managing a list of items with search and delete functionalities. The use of
useMemofor performance optimization, handling of loading states, safe delete functionality with a confirmation modal, and pagination-like functionality are all great features.Some additional suggestions for improvement:
- Consider adding a debounce function to the search input to reduce the number of re-renders when the user is typing quickly.
- If the
dataprop is expected to be large, consider implementing infinite scrolling instead of the current pagination-like functionality to improve performance and user experience.- Add some unit tests to ensure the component behaves as expected and to catch any potential bugs.
Overall, great work on this component!
src/domain/shared/components/SearchableList/SimpleSearchableTable.tsx (1)
26-39: Consider improving the prop types for consistency and clarity.The
SearchableListPropsinterface has a couple of props that could be improved:
The
activeprop is optional and can be a number or string, which might lead to type confusion. Consider using a more specific type to avoid ambiguity.The
itemActionsprop can be a function or a ReactNode, which provides flexibility but might lead to inconsistent usage. Consider separating it into two props: one for a function and one for a ReactNode to encourage consistent usage.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (46)
- src/core/apollo/generated/apollo-helpers.ts (3 hunks)
- src/core/apollo/generated/apollo-hooks.ts (6 hunks)
- src/core/apollo/generated/graphql-schema.ts (6 hunks)
- src/core/i18n/en/translation.en.json (2 hunks)
- src/core/ui/avatar/Avatar.tsx (1 hunks)
- src/domain/collaboration/activity/ActivityLog/views/ActivityIcon.tsx (2 hunks)
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/AdminOrganizationsPage.tsx (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/LicensePlanDialog.tsx (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/ManageLicensePlanAccount.graphql (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/adminGlobalOrganizationsList.graphql (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/useAdminGlobalOrganizationsList.ts (2 hunks)
- src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx (4 hunks)
- src/domain/innovationHub/InnovationHubsAdmin/AdminInnovationHubsPage.tsx (2 hunks)
- src/domain/journey/common/JourneyAvatar/JourneyAvatar.tsx (1 hunks)
- src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (4 hunks)
- src/domain/journey/common/tabs/Subentities/ChildJourneyView.tsx (1 hunks)
- src/domain/journey/space/SpaceContext/SpaceContext.tsx (4 hunks)
- src/domain/journey/space/layout/SpaceTabs.tsx (2 hunks)
- src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (2 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/AdminChallengesPage.graphql (2 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/SubspaceListPage.tsx (1 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (7 hunks)
- src/domain/journey/space/pages/SpaceSubspacesPage.tsx (2 hunks)
- src/domain/journey/subspace/forms/CreateSubspaceForm.tsx (1 hunks)
- src/domain/journey/subspace/icon/SubspaceIcon.tsx (1 hunks)
- src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfileView.tsx (2 hunks)
- src/domain/journey/subspace/subspaceCard/SubspaceCard.tsx (2 hunks)
- src/domain/platform/admin/components/ListPage.tsx (1 hunks)
- src/domain/platform/admin/components/Organization/OrganizationForm.tsx (1 hunks)
- src/domain/platform/admin/components/SearchableList.tsx (4 hunks)
- src/domain/platform/admin/components/SearchableTable.tsx (1 hunks)
- src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (3 hunks)
- src/domain/platform/admin/organization/views/OrganizationGroupsView.tsx (2 hunks)
- src/domain/platform/admin/space/AdminSpaceListPage/SpaceList.tsx (3 hunks)
- src/domain/platform/admin/space/storage/useStorageAdminTree.tsx (2 hunks)
- src/domain/platform/admin/subspace/routing/ChallengesRoute.tsx (1 hunks)
- src/domain/platform/admin/templates/InnovationPacks/admin/AdminInnovationPacksPage.tsx (2 hunks)
- src/domain/shared/components/JourneyIcon/JourneyIcon.tsx (2 hunks)
- src/domain/shared/components/SearchableList/SearchableListLayout.tsx (2 hunks)
- src/domain/shared/components/SearchableList/SimpleSearchableList.tsx (0 hunks)
- src/domain/shared/components/SearchableList/SimpleSearchableTable.tsx (1 hunks)
- src/domain/shared/icons/profileIcons.ts (2 hunks)
- src/main/admin/authorizationPolicies/AuthorizationPrivilegesForUser.tsx (2 hunks)
- src/main/admin/users/adminUsers/AdminUsersPage.tsx (1 hunks)
- src/main/search/searchResults/useHydratedCard.tsx (3 hunks)
Files not reviewed due to no reviewable changes (1)
- src/domain/shared/components/SearchableList/SimpleSearchableList.tsx
Files skipped from review due to trivial changes (2)
- src/domain/journey/subspace/forms/CreateSubspaceForm.tsx
- src/domain/journey/subspace/icon/SubspaceIcon.tsx
Additional comments not posted (142)
src/domain/community/contributor/organization/adminOrganizations/ManageLicensePlanAccount.graphql (2)
1-9: LGTM!The
AssignLicensePlanToAccountmutation is well-structured and follows GraphQL best practices. The mutation signature, parameters, and return type are appropriately defined. TheplanDataobject is correctly constructed using the provided parameters.
11-19: LGTM!The
RevokeLicensePlanFromAccountmutation is well-structured and follows GraphQL best practices. The mutation signature, parameters, and return type are appropriately defined. TheplanDataobject is correctly constructed using the provided parameters.src/domain/journey/common/JourneyAvatar/JourneyAvatar.tsx (2)
3-3: LGTM!The updated import statement is correct and necessary to support the new
sizeprop in theJourneyAvatarPropsinterface.
9-9: LGTM!The new optional
sizeprop in theJourneyAvatarPropsinterface enhances the configurability of theJourneyAvatarcomponent by allowing developers to specify custom avatar sizes. The default value of'large'ensures backward compatibility with existing usages of the component.src/domain/journey/space/pages/SpaceSubspaces/SubspaceListPage.tsx (3)
4-4: LGTM!The import statement has been correctly updated to align with the component's new focus on subspaces.
7-7: LGTM!The component has been appropriately renamed to reflect the shift from challenges to subspaces. The props and structure remain intact.
10-10: LGTM!The
SubspaceListViewcomponent has been correctly used to replaceChallengeListView, aligning with the refactor to focus on subspaces.src/domain/journey/space/pages/SpaceSubspaces/AdminChallengesPage.graphql (2)
1-1: LGTM!The query name change from
AdminSpaceChallengesPagetoAdminSpaceSubspacesPageis consistent with the PR objective of renaming all instances of 'challenge/challenges' to 'subspace/subspaces'. The change is localized to the query name and does not affect the query arguments or selection set.
10-12: Verify the client code for handling the newcardBannerfield.The addition of the
cardBannerfield to thesubspacesselection set is a good enhancement that provides more visual context for each subspace. The field is correctly typed asvisual(type: CARD)and uses theVisualUrifragment to retrieve the necessary data.Please ensure that the client code is updated to handle the new
cardBannerfield and that the visual representation is correctly displayed in the user interface.Run the following script to verify the usage of the
cardBannerfield in the client code:Verification successful
Approve the addition of the
cardBannerfieldThe addition of the
cardBannerfield to thesubspacesselection set is consistent with its usage throughout the codebase. The field is widely used in various components and GraphQL queries, indicating that it's a well-integrated part of the application's visual representation system for spaces and journeys.Key observations:
- The
cardBannerfield is used in multiple React components, includingSpaceExplorerView,RecentJourneyCard, andDashboardSpacesSection.- It's properly typed in GraphQL schema and TypeScript interfaces.
- The field is consistently used alongside other profile-related information.
Based on this analysis, the addition of the
cardBannerfield is approved, and no further client-side updates appear to be necessary.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `cardBanner` field in the client code. # Test: Search for the usage of the `cardBanner` field. Expect: Occurrences in the client code. rg --type tsx --type ts --type js $'cardBanner'Length of output: 74
Script:
#!/bin/bash # Description: Verify the usage of the `cardBanner` field in the client code using multiple approaches. # Search for 'cardBanner' in all files, excluding certain directories echo "Searching for 'cardBanner' in all files:" rg 'cardBanner' --glob '!{node_modules,dist,build}/**' # Use ast-grep to search for 'cardBanner' field access in JavaScript/TypeScript files echo "Searching for 'cardBanner' field access using ast-grep:" ast-grep --lang javascript --pattern '$_.$_cardBanner' # Use find and grep to search for 'cardBanner' in specific file types echo "Searching for 'cardBanner' in .js, .jsx, .ts, and .tsx files:" find . -type f \( -name "*.js" -o -name "*.jsx" -o -name "*.ts" -o -name "*.tsx" \) -not -path "*/node_modules/*" -not -path "*/dist/*" -not -path "*/build/*" -exec grep -Hn 'cardBanner' {} +Length of output: 19782
src/main/admin/users/adminUsers/AdminUsersPage.tsx (2)
14-14: LGTM!The change to use
SimpleSearchableTablefor rendering the user list looks good, assuming it's a compatible replacement forSimpleSearchableListas discussed in the previous comment.This should enhance the presentation and interaction model of the user list as per the AI summary.
6-6: Verify compatibility ofSimpleSearchableTablewithSimpleSearchableList.The change from using
SimpleSearchableListtoSimpleSearchableTablefor displaying user data looks good and should enhance the presentation and interaction model as per the AI summary.However, please ensure that
SimpleSearchableTableis a drop-in replacement forSimpleSearchableListand accepts the same props to avoid any breakages.Run the following script to verify the props of
SimpleSearchableTable:src/domain/platform/admin/subspace/routing/ChallengesRoute.tsx (2)
6-6: LGTM!The import statement change is consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'.
12-12: Verify the user interface and experience changes.The route element change is consistent with the PR objective of replacing the legacy Space list with a new list format utilizing
JourneyCardHorizontal.Please ensure that the
SubspaceListPagecomponent provides the expected user interface and experience at the index route. Verify that the new list format and actions menu are functioning as intended.src/domain/platform/admin/components/ListPage.tsx (5)
8-8: Verify the usage of theListPagePropsinterface.The change in the
Itemtype parameter to extendSearchableTableItemlooks good and is consistent with the transition to a table format.Please ensure that all usages of the
ListPagePropsinterface have been updated to provideSearchableTableItemcompatible data. You can use the following script to search for the interface usage and analyze the provided data:Verification successful
ListPageProps usage is correct and consistent
The verification process confirms that the
ListPagePropsinterface is correctly defined and used within thesrc/domain/platform/admin/components/ListPage.tsxfile. TheItemtype parameter extendsSearchableTableItemas expected, and theListPagecomponent correctly uses the updated interface.No other direct usages of
ListPagePropswere found in the codebase, suggesting thatListPagemight be the only component using this interface. This means the change is localized and consistent within the file.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `ListPageProps` interface. # Test: Search for the interface usage. Expect: Usage found with `SearchableTableItem` compatible data. rg --type typescript -A 5 $'ListPageProps<'Length of output: 79
Script:
#!/bin/bash # Description: Search for ListPageProps usage in TypeScript files # Find TypeScript files and search for ListPageProps usage fd '\.(ts|tsx)$' | xargs rg -n -C 5 'ListPageProps<'Length of output: 2057
9-9: Verify the definition of theSearchableTablePropsinterface.The change in the extended interface to
SearchableTablePropslooks good and is consistent with the transition to a table format.Please ensure that the
SearchableTablePropsinterface is defined correctly and all its properties are compatible with theListPagecomponent. You can use the following script to search for the interface definition and analyze its properties:Verification successful
SearchableTableProps interface verified and correctly used
The SearchableTableProps interface is properly defined in
src/domain/platform/admin/components/SearchableTable.tsxand correctly imported and used insrc/domain/platform/admin/components/ListPage.tsx. The interface is generic, which aligns with its usage in the ListPage component. No issues were found during the verification process.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition of the `SearchableTableProps` interface. # Test: Search for the interface definition. Expect: Interface definition found with compatible properties. ast-grep --lang typescript --pattern $'interface SearchableTableProps<$_, $_> { $$$ }'Length of output: 89
Script:
#!/bin/bash # Description: Search for SearchableTableProps and related interfaces/types # Search for any mention of SearchableTableProps echo "Searching for SearchableTableProps:" rg "SearchableTableProps" -n # Search for similar interface names echo -e "\nSearching for similar interface names:" rg "interface.*Table.*Props" -n # Search for type aliases related to table props echo -e "\nSearching for type aliases related to table props:" rg "type.*Table.*Props" -n # Check the import statement in ListPage.tsx echo -e "\nChecking import statement in ListPage.tsx:" rg "import.*SearchableTableProps" src/domain/platform/admin/components/ListPage.tsx -nLength of output: 1662
16-16: Verify the usage of theListPagecomponent.The change in the
Itemtype parameter to extendSearchableTableItemlooks good and is consistent with the transition to a table format.Please ensure that all usages of the
ListPagecomponent have been updated to provideSearchableTableItemcompatible data. You can use the following script to search for the component usage and analyze the provided data:
24-24: Verify the usage of theSearchableTablecomponent.The change in the rendered component to
SearchableTablelooks good and is consistent with the transition to a table format.Please ensure that the
SearchableTablecomponent is implemented correctly and all its required props are provided. You can use the following script to search for the component usage and analyze the provided props:Verification successful
SearchableTable usage verified and approved
The
SearchableTablecomponent is being used correctly in theListPagecomponent. The import statement includes the necessary types (SearchableTableItemandSearchableTableProps), indicating proper type checking. The usage of the spread operator ({...props}) suggests that theListPagecomponent is designed to pass down the required props toSearchableTable.Other instances of
SearchableTableusage in the codebase (e.g., inOpportunityList.tsx) confirm that it typically expects props likedataand potentiallyonDelete. The widespread usage of this component and its variants across the project indicates it's a well-established and likely well-tested component.Given this information, the change to use
SearchableTableinListPageis appropriate and consistent with the codebase's patterns.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `SearchableTable` component. # Test: Search for the component usage. Expect: Usage found with required props provided. rg --type typescript -A 5 $'<SearchableTable'Length of output: 81
Script:
#!/bin/bash # Description: Verify the usage of the `SearchableTable` component. # Search for SearchableTable component usage in .tsx and .ts files echo "Searching for SearchableTable component usage:" rg '<SearchableTable' -g '*.{tsx,ts}' -A 5 # Search for imports of SearchableTable echo "\nSearching for SearchableTable imports:" rg "import.*SearchableTable" -g '*.{tsx,ts}'Length of output: 3686
2-2: Verify theSearchableTablecomponent implementation.The import statement change looks good and aligns with the PR objective of preparing for
ListTableintegration.Please ensure that the
SearchableTablecomponent is implemented correctly and all its dependencies are properly imported. You can use the following script to search for the component definition and analyze its implementation:Verification successful
SearchableTable component implementation verified
The SearchableTable component and its related interfaces are correctly implemented in
src/domain/platform/admin/components/SearchableTable.tsx. The file contains:
- SearchableTableProps interface (exported)
- SearchableTableItem interface (exported)
- SearchableTable component (exported as const)
- Default export of SearchableTable
These exports align with the import statement in ListPage.tsx. The component is implemented as a const arrow function, which is a valid React component definition.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of the `SearchableTable` component. # Test: Search for the component definition. Expect: Component definition found. ast-grep --lang typescript --pattern $'export default function SearchableTable($_) { $$$ }' # Test: Search for the component's props interface. Expect: Props interface found. ast-grep --lang typescript --pattern $'interface SearchableTableProps<$_, $_> { $$$ }'Length of output: 184
Script:
#!/bin/bash # Description: Further investigate the SearchableTable component implementation # Test 1: Check if the SearchableTable.tsx file exists echo "Checking for SearchableTable.tsx file:" fd SearchableTable.tsx # Test 2: Search for any component definition or export in SearchableTable.tsx echo -e "\nSearching for component definition or export:" rg -n "export.*SearchableTable" --type ts # Test 3: Look for any interface or type definition related to SearchableTable props echo -e "\nSearching for SearchableTable props interface or type:" rg -n "type SearchableTableProps|interface SearchableTableProps" --type ts # Test 4: Check for any React component definition patterns echo -e "\nSearching for React component patterns:" ast-grep --lang typescript --pattern 'const SearchableTable = $_' ast-grep --lang typescript --pattern 'class SearchableTable extends $_'Length of output: 1757
src/domain/shared/components/JourneyIcon/JourneyIcon.tsx (4)
2-2: LGTM!The import statement change from
ChallengeIcontoSubspaceIconis consistent with the renaming effort and looks good.
13-13: LGTM!The update to the
journeyIconobject to useSubspaceIconinstead ofChallengeIconfor thesubspacekey is consistent with the renaming effort and looks good.
19-19: LGTM!The update to the
journeyIconByJourneyLevelarray to useSubspaceIconinstead ofChallengeIconat index 1 is consistent with the renaming effort and looks good.
26-26: LGTM!The update to the
spaceTypeIconrecord to useSubspaceIconinstead ofChallengeIconfor theSpaceType.Challengekey is consistent with the renaming effort and looks good.src/domain/journey/space/layout/SpaceTabs.tsx (2)
8-8: LGTM!The import change from
ChallengeIcontoSubspaceIconaligns with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. This change in visual representation is consistent with the shift towards subspaces.
27-28: Verify the permission check update across the codebase.The component change from
ChallengeIcontoSubspaceIconaligns with the import change and the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'.The permission check update from
permissions.canReadChallengestopermissions.canReadSubspacessuggests that the functionality now aligns more closely with subspaces rather than challenges. This potentially alters how users interact with these features based on their permissions.Please ensure that this permission check update has been consistently applied across the codebase to avoid any unintended access or restrictions.
Run the following script to verify the permission check update:
Verification successful
Permission check update verified and consistently applied
The verification process has confirmed that the permission check update from
permissions.canReadChallengestopermissions.canReadSubspaceshas been successfully and consistently applied across the codebase.Key findings:
- The old permission check
permissions.canReadChallengeshas been completely removed.- The new permission check
permissions.canReadSubspacesis present in the expected locations:
- src/domain/journey/space/layout/SpaceTabs.tsx
- src/domain/journey/space/pages/SpaceSubspacesPage.tsx
These results align with the changes observed in the original code snippet and support the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the permission check update from `permissions.canReadChallenges` to `permissions.canReadSubspaces` across the codebase. # Test 1: Search for the old permission check. Expect: No occurrences. rg --type typescript $'permissions.canReadChallenges' # Test 2: Search for the new permission check. Expect: Only occurrences of the new permission check. rg --type typescript $'permissions.canReadSubspaces'Length of output: 174
Script:
#!/bin/bash # Description: Verify the permission check update from `permissions.canReadChallenges` to `permissions.canReadSubspaces` across the codebase. # Test 1: Search for the old permission check using rg. Expect: No occurrences. echo "Searching for old permission check (rg):" rg "permissions\.canReadChallenges" --type-add 'ts:*.{ts,tsx}' -t ts # Test 2: Search for the new permission check using rg. Expect: Only occurrences of the new permission check. echo "Searching for new permission check (rg):" rg "permissions\.canReadSubspaces" --type-add 'ts:*.{ts,tsx}' -t ts # Test 3: Search for the old permission check using ast-grep. Expect: No occurrences. echo "Searching for old permission check (ast-grep):" ast-grep --lang typescript --pattern 'permissions.canReadChallenges' # Test 4: Search for the new permission check using ast-grep. Expect: Only occurrences of the new permission check. echo "Searching for new permission check (ast-grep):" ast-grep --lang typescript --pattern 'permissions.canReadSubspaces'Length of output: 879
src/domain/community/contributor/organization/adminOrganizations/adminGlobalOrganizationsList.graphql (3)
10-19: LGTM! The extended query enhances organization data retrieval.The addition of the
verificationandsubscriptionsfields to theadminGlobalOrganizationsListquery is a valuable enhancement. It allows for retrieving more comprehensive data about organizations, including their verification status and active subscriptions.The
verificationfield, with itsidandlifecyclestate, provides granular details about the verification process for each organization. This information can be utilized in the UI to display the current verification status and enable administrators to take appropriate actions based on the lifecycle state.Similarly, the
subscriptionsfield enables fetching the names of active subscriptions for each organization. This data can be used to provide an overview of the subscriptions associated with each organization, facilitating better management and decision-making.Overall, these changes enhance the query's capabilities and provide more comprehensive data retrieval for organizations.
25-36: Great addition! Including platform and licensing data enhances the query.The inclusion of the
platformfield within theadminGlobalOrganizationsListquery is a valuable addition. It allows for retrieving platform-specific data alongside the organization information, providing a more comprehensive view.The
licensingfield withinplatformis particularly useful as it enables access to licensing-related information. Theplansfield withinlicensingallows for fetching details about available license plans, including theirid,name,type, andlicenseCredential. This data can be utilized in the UI to display relevant licensing information and facilitate better management and decision-making related to organizations and their licenses.By including platform and licensing data within the
adminGlobalOrganizationsListquery, administrators can have a more holistic view of the organizations and their associated licensing details. This enhancement improves the overall functionality and usability of the query.
39-57: Excellent additions! The new queries enhance organization-related functionality.The introduction of the
AccountOnOrganizationquery and theadminOrganizationVerifymutation is a significant enhancement to the GraphQL schema.The
AccountOnOrganizationquery allows for retrieving the account associated with a specific organization by taking anorganizationIdas input. This query can be extremely useful in scenarios where account-related information is required for a given organization. It provides a convenient way to fetch the necessary account data without the need for additional queries or complex logic.The
adminOrganizationVerifymutation is another valuable addition. It enables administrators to trigger verification events on organizations by accepting anOrganizationVerificationEventInputas input. This mutation empowers administrators to initiate and manage the verification process for organizations directly through the GraphQL API.Furthermore, the mutation returns the
idandlifecycledetails of the verification process, including thenextEventsandstate. This information is crucial for tracking the progress of the verification process and taking appropriate actions based on the current state and upcoming events. Administrators can utilize this data to monitor the verification status and make informed decisions.Overall, these new queries significantly enhance the organization-related functionality of the GraphQL schema, providing more granular control and data retrieval capabilities.
src/core/ui/avatar/Avatar.tsx (1)
6-6: LGTM!Exporting the
Sizetype is a good change that promotes code reusability and maintainability. It allows the type to be consumed by other modules that use theAvatarcomponent.src/domain/shared/components/SearchableList/SearchableListLayout.tsx (3)
1-7: LGTM!The new imports are necessary for the updated button component and layout changes. The custom
RouterLinkcomponent is a good replacement for theLinkcomponent fromreact-router-dom, and theguttersutility is used appropriately to add horizontal padding to the layout.
20-20: LGTM!The horizontal padding is added correctly to the
Gridcontainer item using thepaddingXprop and theguttersutility function.
25-29: LGTM!The Material-UI
Buttoncomponent is a good replacement for the previousWrapperButtoncomponent. TheAddOutlinedIconis used appropriately as thestartIconto visually indicate the action of adding a new item. The customRouterLinkcomponent is used correctly for navigation, and the button text is properly translated using thet('buttons.create')function.src/domain/platform/admin/organization/views/OrganizationGroupsView.tsx (2)
6-6: Verify the usage ofSearchableTableItemthroughout the file.The import statement change from
SearchableListItemtoSearchableTableItemsuggests a shift in the data representation. Please ensure that:
- The
SearchableTableItemtype is being used correctly in all relevant places within this file.- The corresponding component (e.g.,
SearchableTable) has been updated to handle the new data structure.
32-32: Verify the delete functionality with the newSearchableTableItemtype.The type change in the
handleDeleteGroupfunction fromSearchableListItemtoSearchableTableItemis consistent with the import statement change. Please ensure that:
- The
idproperty is still accessible from theSearchableTableItemtype.- The delete functionality works as expected with the new data structure.
src/domain/collaboration/activity/ActivityLog/views/ActivityIcon.tsx (2)
12-12: Verify the existence of theSubspaceIconcomponent.The import statement change is consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. Please ensure that the
SubspaceIconcomponent is implemented correctly in thesrc/domain/journey/subspace/icon/SubspaceIconfile.Run the following script to verify the existence of the
SubspaceIconcomponent:Verification successful
SubspaceIcon component verified successfully
The verification process has confirmed that the SubspaceIcon component exists and is correctly implemented:
- The file "src/domain/journey/subspace/icon/SubspaceIcon.tsx" is present in the codebase.
- The SubspaceIcon component is properly declared and exported in the file.
This validates the change in the import statement and ensures that the SubspaceIcon component is available for use in the ActivityIcon.tsx file.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the `SubspaceIcon` component. # Test: Check if the `SubspaceIcon` component file exists. Expect: The file should exist. if [ -f "src/domain/journey/subspace/icon/SubspaceIcon.tsx" ]; then echo "The SubspaceIcon component file exists." else echo "The SubspaceIcon component file does not exist." exit 1 fi # Test: Search for the `SubspaceIcon` component declaration. Expect: The component should be declared and exported. grep -q "export const SubspaceIcon" src/domain/journey/subspace/icon/SubspaceIcon.tsx if [ $? -eq 0 ]; then echo "The SubspaceIcon component is declared and exported." else echo "The SubspaceIcon component is not declared or exported." exit 1 fiLength of output: 372
27-27: Verify the consistent usage of theSubspaceIconacross the application.The change to map the
ActivityEventType.ChallengeCreatedto theSubspaceIconis consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. Please ensure that theSubspaceIconis used consistently across the application for subspace-related entities.Run the following script to verify the consistent usage of the
SubspaceIconacross the application:Verification successful
SubspaceIcon usage is consistent, and ChallengeIcon has been fully replaced
The verification process confirms that:
- The SubspaceIcon is used consistently across the application for subspace-related entities, including the change made in ActivityIcon.tsx.
- There are no remaining references to ChallengeIcon in the src directory, indicating a successful renaming from 'challenge' to 'subspace' throughout the codebase.
The change is approved and aligns well with the overall PR objective.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistent usage of the `SubspaceIcon` across the application. # Test: Search for the usage of the `SubspaceIcon` component. Expect: The component should be used consistently for subspace-related entities. rg --type tsx --type ts --glob '!SubspaceIcon.tsx' 'SubspaceIcon' src/domain/journey/subspaceLength of output: 121
Script:
#!/bin/bash # Description: Verify the consistent usage of the `SubspaceIcon` across the application. # Find all .tsx and .ts files in the src directory, excluding SubspaceIcon.tsx, # then search for SubspaceIcon usage in these files fd -e tsx -e ts -E '**/SubspaceIcon.tsx' . src | xargs rg 'SubspaceIcon' # Additionally, search for any remaining references to ChallengeIcon rg 'ChallengeIcon' srcLength of output: 2484
src/domain/journey/subspace/subspaceCard/SubspaceCard.tsx (1)
38-38: LGTM!The change from
ChallengeIcontoSubspaceIconfor theiconComponentprop is consistent with the renaming effort from 'challenge' to 'subspace' mentioned in the PR objectives. It should not affect the functionality of the component and will align the visual representation of the subspace card with the intended thematic representation of subspaces.src/domain/innovationHub/InnovationHubsAdmin/AdminInnovationHubsPage.tsx (1)
Line range hint
48-56: Verify the impact of the UI change on user experience and accessibility.The change from
SimpleSearchableListtoSimpleSearchableTablesuggests a change in the UI from a list to a table. While the functionality remains the same, it's important to verify the following:
- The table UI provides a better user experience compared to the list UI.
- The table UI meets the accessibility standards.
To verify the impact of the change, please provide the following:
- Screenshots of the old list UI and the new table UI.
- Accessibility test results for the new table UI.
If the above verification is successful, then the change can be merged.
src/domain/platform/admin/templates/InnovationPacks/admin/AdminInnovationPacksPage.tsx (2)
12-12: LGTM!The change from
SimpleSearchableListtoSimpleSearchableTablelooks good. It should enhance the UI by providing a table format for displaying innovation packs data.Also applies to: 49-57
12-12: Verify theSimpleSearchableTablecomponent.Please ensure that the
SimpleSearchableTablecomponent accepts the same props and behaves similarly to theSimpleSearchableListcomponent it is replacing. This will help avoid any unintended side effects or broken functionality.Run the following script to verify the props and behavior:
Also applies to: 49-57
Verification successful
Verification successful:
SimpleSearchableTableappears to be a suitable replacementThe
SimpleSearchableTablecomponent seems to be a direct and appropriate replacement forSimpleSearchableList. It is consistently used across multiple admin pages (Innovation Packs, Innovation Hubs, Organizations, Users) with similar props, includingdata,onDelete,loading,fetchMore, andpageSize, which align with the expectations mentioned in the original review comment.While the code analysis suggests that the component behaves similarly to its predecessor, it's recommended to manually verify the following:
- Ensure that any custom functionality specific to the Innovation Packs page is properly handled by the new component.
- Confirm that the table rendering and interaction behave as expected in the context of the Innovation Packs admin page.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify SimpleSearchableTable component props and behavior. # Test 1: Search for the SimpleSearchableTable component definition. # Expect: It should accept the same props as SimpleSearchableList. ast-grep --lang typescript --pattern $'const SimpleSearchableTable = ({ $$$ data, onDelete, loading, fetchMore, pageSize, searchTerm, onSearchTermChange, hasMore, $$$ }: SimpleSearchableTableProps) => { $$$ }' # Test 2: Search for usage of SimpleSearchableTable in other files. # Expect: It should be used similarly to SimpleSearchableList. rg --type typescript -A 5 $'SimpleSearchableTable'Length of output: 317
Script:
#!/bin/bash # Description: Verify SimpleSearchableTable component props and behavior. # Search for any mention of SimpleSearchableTable ast-grep --lang typescript --pattern 'SimpleSearchableTable' # Search for usage of SimpleSearchableTable in TypeScript files rg --type ts -A 5 'SimpleSearchableTable' # Search for SimpleSearchableList for comparison rg --type ts -A 5 'SimpleSearchableList' # Search for the import statement of SimpleSearchableTable rg --type ts 'import.*SimpleSearchableTable'Length of output: 8632
src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx (4)
3-3: LGTM!The import statement has been correctly updated to import
SearchableTableIteminstead ofSearchableListItem, aligning with the transition mentioned in the AI-generated summary.
16-16: LGTM!The type of
userListin theProvidedinterface has been correctly updated toSearchableTableItem[], aligning with the transition mentioned in the AI-generated summary.
17-17: LGTM!The type of the
itemparameter in theonDeletefunction of theProvidedinterface has been correctly updated toSearchableTableItem, aligning with the transition mentioned in the AI-generated summary.
Line range hint
66-70: LGTM!The mapping function that constructs the
userListhas been correctly updated to returnSearchableTableIteminstead ofSearchableListItem, aligning with the transition mentioned in the AI-generated summary. The properties being accessed and returned in the mapping function are consistent with theSearchableTableItemtype.src/domain/shared/icons/profileIcons.ts (2)
5-5: LGTM!The import change from
ChallengeIcontoSubspaceIconis consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. It does not affect the overall functionality of thegetProfileIconfunction.
36-36: LGTM!Replacing
ChallengeIconwithSubspaceIconin the switch statement forProfileType.Challengeis consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. It does not affect the overall functionality of thegetProfileIconfunction.src/main/admin/authorizationPolicies/AuthorizationPrivilegesForUser.tsx (2)
9-9: LGTM!The change from
SearchableListItemtoSearchableTableItemaligns with the AI-generated summary and is likely to enhance the functionality or user experience by leveraging a table format instead of a list.
39-39: LGTM!The change in the parameter type for
valuein thehandleUserInputChangefunction is consistent with the import statement change at line 9 and the AI-generated summary. It reflects the shift fromSearchableListItemtoSearchableTableItemand is likely to enhance the functionality or user experience by leveraging a table format instead of a list.src/domain/platform/admin/space/AdminSpaceListPage/SpaceList.tsx (3)
12-12: LGTM!The import statement has been updated correctly to import
SearchableTableItemandSearchableTableItemMapperfrom theSearchableTablecomponent. This change aligns with the refactoring from list-based to table-based representation for space items.
62-62: Looks good!The usage of
SearchableTableItemMapperto map thespaceobject is correct and consistent with the updated import statement. The mapper is being applied correctly to transform thespaceobject into aSearchableTableItem.
80-80: Parameter type updated correctly.The
handleDeletefunction's parameter type has been updated fromSearchableListItemtoSearchableTableItem, which is consistent with the other changes in the file related to the shift from list-based to table-based representation. The function implementation remains the same, and there are no apparent issues with the parameter type change.src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (3)
18-18: LGTM!The
Sizetype is correctly imported from theAvatarmodule.
49-49: LGTM!The
sizeproperty is correctly added to theJourneyCardHorizontalPropsinterface with the appropriate type and optional modifier.
63-63: LGTM!The
sizeproperty is correctly destructured from theJourneyCardHorizontalPropsobject.src/domain/platform/admin/components/SearchableList.tsx (5)
1-7: LGTM!The new imports for
JourneyCardHorizontalandVisualcomponents are correctly specified. These imports suggest that theSearchableListcomponent will now useJourneyCardHorizontalfor rendering list items andVisualfor handling visual elements, which aligns with the refactoring objectives mentioned in the PR summary.
16-16: LGTM!The new optional
getActionsprop in theSearchableListPropsinterface is a great addition. It provides a way to define custom actions for each list item, allowing for more flexible action rendering per item. The prop is correctly typed as a function that takes aSearchableListItemand returns aReactNodeorundefined, and it is optional, which maintains backward compatibility.
24-38: LGTM!The modifications to the
SearchableListIteminterface to include aprofileobject are well-structured. Theprofileobject encapsulates the properties related to the display of a list item, withdisplayNameandurlbeing required, andtagline,avatar, andcardBannerbeing optional. The use of theVisualtype for theavatarandcardBannerproperties aligns with the importedVisualcomponent. These changes support the refactoring objective to enhance the visual representation of each list item.
59-60: LGTM!The update to the filtering logic to search through the
displayNamewithin theprofileobject is implemented correctly. The use ofuseMemoto computefilteredDataoptimizes performance by memoizing the filtered results. The filtering logic checks if the lowercasedisplayNameincludes the lowercasefilterByvalue, and the optional chaining operator?.is used to safely access thedisplayNameproperty. This change aligns with the refactoring of theSearchableListIteminterface to include theprofileobject.
76-98: LGTM!The update to the rendering logic for list items to use the
JourneyCardHorizontalcomponent is a great improvement. TheJourneyCardHorizontalcomponent is rendered with appropriate props likesize,journeyTypeName,journey,deepness,seamless,sx, andactions, which enhance the visual representation of each list item. Thejourneyprop is set using theprofileobject from theSearchableListItem, ensuring the correct data is passed to the component. Theactionsprop is conditionally set based on thegetActionsprop, allowing for custom actions per item. Additionally, the loading state rendering has been updated to render multipleLoadingListItemcomponents, providing a better visual indication of the loading process.src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (2)
56-56: LGTM!The update to the
handleDeletefunction signature, accepting an argument of typeSearchableTableItem, aligns with the transition to theSearchableTablecomponent.
118-118: Looks good!The replacement of
SearchableListwithSearchableTableand the updatedonDeleteprop are in line with the transition to a table-based UI for displaying opportunities.src/domain/journey/space/SpaceContext/SpaceContext.tsx (8)
18-19: LGTM!The interface change is consistent with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'.
52-52: Looks good!The default value change for
canCreateSubspacesis consistent with the update to theSpacePermissionsinterface.
54-54: LGTM!The default value change for
canReadSubspacesis consistent with the update to theSpacePermissionsinterface.
101-101: Looks good!The logic for setting
canReadSubspacesbased on thespacePrivilegesarray is correct.
102-102: LGTM!The logic for setting
canCreateSubspacesbased on thespacePrivilegesarray is correct.
111-111: Looks good!The inclusion of
canReadSubspacesin theSpacePermissionsobject is consistent with the update to theSpacePermissionsinterface.
112-112: LGTM!The inclusion of
canCreateSubspacesin theSpacePermissionsobject is consistent with the update to theSpacePermissionsinterface.
118-118: Looks good!The inclusion of
canReadSubspacesandcanCreateSubspacesin theuseMemohook dependencies array is necessary to ensure that the memoized value is recomputed when these variables change.src/domain/journey/space/pages/SpaceSubspacesPage.tsx (9)
20-20: LGTM!The import statement has been correctly updated to reflect the renaming of
ChallengeIcontoSubspaceIcon.
22-22: LGTM!The import statement has been correctly updated to reflect the renaming of
CreateChallengeFormtoCreateSubspaceForm.
70-70: LGTM!The
childEntitiesIconprop has been correctly updated to useSubspaceIcon, which is consistent with the renaming.
71-71: LGTM!The
childEntityReadAccessprop has been correctly updated to usepermissions.canReadSubspaces, which is consistent with the renaming.
76-76: LGTM!The
renderChildEntityCardprop has been correctly updated to useitemas the parameter, which is consistent with the renaming.
78-86: LGTM!The usage of
SubspaceCardand the props passed to it are consistent with the renaming and correctly represent the properties of a subspace entity.
90-90: LGTM!The
childEntityCreateAccessprop has been correctly updated to usepermissions.canCreateSubspaces, which is consistent with the renaming.
95-95: LGTM!The
iconprop of theJourneyCreationDialogcomponent has been correctly updated to useSubspaceIcon, which is consistent with the renaming.
99-99: LGTM!The
formComponentprop of theJourneyCreationDialogcomponent has been correctly updated to useCreateSubspaceForm, which is consistent with the renaming.src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfileView.tsx (2)
7-7: LGTM!The renaming of
refetchAdminSpaceChallengesPageQuerytorefetchAdminSpaceSubspacesPageQueryaligns with the PR objective of shifting the terminology from challenges to subspaces. This change is crucial as it directly affects the data flow and the user experience following the creation of a subspace.
44-44: Looks good!Using the
refetchAdminSpaceSubspacesPageQueryin therefetchQueriesoption of theuseCreateSubspaceMutationhook ensures that the admin space subspaces page is refetched with the latest data after a new subspace is created. This will keep the UI in sync with the server state.src/domain/community/contributor/organization/adminOrganizations/AdminOrganizationsPage.tsx (9)
1-3: LGTM!The new imports are relevant to the changes made in the component and are used appropriately.
8-14: LGTM!The new imports are relevant to the changes made in the component and are used appropriately.
17-18: LGTM!The
useTranslationanduseAdminGlobalOrganizationsListhooks are used appropriately to enable internationalization and fetch the necessary data for the component.
22-25: LGTM!The state variables are appropriately initialized and named. They are used to manage the UI state and track the selected organization item.
27-49: LGTM!The
onVerificationClick,onCloseConfirmation, andonSettingsClickfunctions are implemented correctly. They handle the user interactions appropriately and update the relevant state variables.
51-59: LGTM!The
assignLicenseandrevokeLicensefunctions are implemented correctly. They handle the license assignment and revocation appropriately by calling the corresponding functions fromlistPropsand updating thelicenseDialogOpenstate.
61-72: LGTM!The
orgActionsfunction is implemented correctly. It renders the settings and verification action buttons for each organization item in the table. The click handlers are set up appropriately, and the color of the verification icon is conditionally set based on the verification status.
74-90: LGTM!The
getStatusTranslationandgetActionTranslationfunctions are implemented correctly. They retrieve the appropriate translations for the verification status and action based on theverifiedproperty of the provideditem. The translations are defined using the correct translation keys.
95-130: LGTM!The rendering logic for the
SimpleSearchableTable,ConfirmationDialog, andLicensePlanDialogcomponents is implemented correctly.
- The
SimpleSearchableTableis configured with theorganizationsdata and the customitemActions.- The
ConfirmationDialogis conditionally rendered based on theconfirmationOpenstate and is properly configured with the necessary actions, options, state, and translated entities.- The
LicensePlanDialogis conditionally rendered based on theselectedItemandlicenseDialogOpenstate and is provided with the required props for license management functionality.The code segment integrates the new components and functionality seamlessly into the existing component structure.
src/domain/shared/components/SearchableList/SimpleSearchableTable.tsx (4)
49-65: LGTM!The
SimpleSearchableListcomponent is properly implemented with:
- Generic type parameter for type safety.
- Destructuring of props with default values.
- Use of
useTranslationhook for internationalization.- Proper state management for the remove modal and the item to remove.
66-77: LGTM!The memoized
Loadercomponent is properly implemented with:
- Memoization using
useMemofor performance optimization.- Use of
forwardRefto pass the ref to the child component.- Correct rendering logic to show the loading state based on the
pageSize.
79-83: LGTM!The
useLazyLoadinghook is used correctly to handle lazy loading of data with:
- The
Loadercomponent passed as an argument.- The necessary props
hasMore,loading, andfetchMorepassed correctly.
110-187: LGTM!The rendering logic of the component is properly implemented with:
- Search input field with the
useTranslationhook for the placeholder.- Table headers with the necessary styling.
- Table rows based on the
dataprop and the loading state.itemActionsprop correctly rendered for each item, handling both function and ReactNode cases.- Remove modal properly shown and hidden based on the state and the delete icon click event.
src/domain/journey/common/tabs/Subentities/ChildJourneyView.tsx (1)
Line range hint
135-141: LGTM!The change in the permission check from
canCreateChallengestocanCreateSubspacesaligns with the overall theme of the PR to rename challenges to subspaces. The rendered UI element remains the same, so this change is unlikely to cause any functional issues.src/domain/community/contributor/organization/adminOrganizations/useAdminGlobalOrganizationsList.ts (8)
22-30: LGTM!The new enums
OrgVerificationLifecycleStatesandOrgVerificationLifecycleEventsprovide a structured way to manage the organization verification lifecycle. The enum values are descriptive and follow a consistent naming convention.
32-35: LGTM!The new interface
OrgLicensePlanprovides a clear structure for the organization license plan object. The interface is exported, indicating that it may be used in other parts of the codebase.
68-108: LGTM!The
handleVerificationfunction provides a centralized way to handle the organization verification process. It handles different verification states and events based on the current state of the organization.The error handling for the
VERIFICATION_REQUESTevent ensures that the verification process can still be completed even if the request fails.
110-123: LGTM!The
getAccountIdfunction provides a utility to retrieve the account ID associated with an organization. It handles the case when theentityIdis not provided and returnsundefined.The function is marked as
async, indicating that it returns a promise that resolves to the account ID.
125-147: LGTM!The
assignLicensePlanfunction provides a way to assign a license plan to an account associated with an organization. It ensures that the account ID is available before performing the mutation.The refetching of the query after the mutation ensures that the data is updated in the UI. The success notification provides feedback to the user about the license assignment.
149-171: LGTM!The
revokeLicensePlanfunction provides a way to revoke a license plan from an account associated with an organization. It follows a similar logic to theassignLicensePlanfunction.It ensures that the account ID is available before performing the mutation. The refetching of the query after the mutation ensures that the data is updated in the UI. The success notification provides feedback to the user about the license revocation.
179-184: LGTM!The addition of the
verifiedandactiveLicensePlanIdsproperties to theorganizationsmemoized value provides convenient access to the verification status and active license plan IDs for each organization.The
verifiedproperty is determined based on the verification lifecycle state, while theactiveLicensePlanIdsproperty is derived from theplatform.licensing.plansdata by filtering and mapping the relevant plans.These properties can be used in other parts of the codebase to make decisions based on the verification status and active license plans of an organization.
189-198: LGTM!The
licensePlansmemoized value provides a convenient way to access the available license plans of typeLicensePlanType.AccountPlan. It simplifies the usage of license plans in other parts of the codebase by providing a pre-filtered and mapped array.The memoization ensures that the
licensePlansvalue is only recomputed when thedatadependency changes, optimizing performance.src/main/search/searchResults/useHydratedCard.tsx (3)
22-22: LGTM!The import statement change from
ChallengeIcontoSubspaceIconaligns with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'.
109-109: LGTM!The updated icon assignment logic based on the parent space type aligns with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. Using
SubspaceIconfor non-space parent types is appropriate.
151-151: LGTM!Updating the icon assignment for
SpaceType.Challengeto useSubspaceIconaligns with the PR objective of renaming 'challenge/challenges' to 'subspace/subspaces'. The change is appropriate and consistent.src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (14)
9-10: LGTM!The imports have been updated to use subspace-related queries, which aligns with the overall refactor of the component to manage subspaces.
18-18: LGTM!The import of
SubspaceIconaligns with the overall refactor of the component to manage subspaces.
21-21: LGTM!The import of
CreateSubspaceFormaligns with the overall refactor of the component to manage subspaces and suggests that a new form component is used for creating subspaces.
28-33: LGTM!The imports of new UI components and icons align with the overall refactor of the component to manage subspaces and enhance the user experience.
35-35: LGTM!The renaming of the exported component from
ChallengeListViewtoSubspaceListViewaligns with the overall refactor to manage subspaces instead of challenges.
43-43: LGTM!The renaming of the query from
useAdminSpaceChallengesPageQuerytouseAdminSpaceSubspacesPageQueryaligns with the overall refactor to manage subspaces instead of challenges.
51-52: LGTM!The introduction of the
deleteDialogOpenanditemToRemovestate variables aligns with the enhanced delete functionality with a confirmation dialog.
58-67: LGTM!The mapping of subspace data to a new structure aligns with the overall refactor to manage subspaces instead of challenges. The structure includes relevant properties for rendering the subspace list.
70-70: LGTM!The renaming of the mutation from
useDeleteSpaceMutationtouseDeleteSubspaceMutationaligns with the overall refactor to manage subspaces instead of challenges. The destructuring and renaming of theloadingproperty improve the handling of the delete mutation's loading state.
72-72: LGTM!The update to the refetch query to
refetchAdminSpaceSubspacesPageQueryafter the delete mutation aligns with the overall refactor to manage subspaces instead of challenges and ensures that the list of subspaces is updated correctly.
Line range hint
80-88: LGTM!The
handleDeletefunction correctly handles the deletion of a subspace item by calling thedeleteSubspacemutation with theidof the item to be deleted, which aligns with the overall refactor to manage subspaces instead of challenges.
90-96: LGTM!The renaming of the mutation from
useCreateSubspaceMutationtouseCreateSubspaceMutationaligns with the overall refactor to manage subspaces instead of challenges. Refetching the subspace page query after the create mutation ensures that the list of subspaces is updated correctly.
Line range hint
100-126: LGTM!The
handleCreatefunction correctly handles the creation of a new subspace by calling thecreateSubspacemutation with the form values, which aligns with the overall refactor to manage subspaces instead of challenges. Navigating to the settings URL of the created subspace after the mutation is completed provides a smooth user experience.
Line range hint
147-230: LGTM!The introduced functions
src/domain/platform/admin/components/Organization/OrganizationForm.tsx (1)
74-74: LGTM!The addition of the
subscriptionsproperty to theEmptyOrganizationobject is a valid enhancement to theOrganizationtype, allowing for the management of subscription-related data.Initializing
subscriptionsas an empty array provides a sensible default value and ensures the property is always present in theOrganizationobject.src/domain/platform/admin/space/storage/useStorageAdminTree.tsx (1)
60-60: LGTM!The change from
ChallengeIcontoSubspaceIconforSpaceLevel.Challengeis consistent with the overall renaming effort mentioned in the PR objectives. The change is localized to this function and does not introduce any functional or logical issues.src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (2)
78-81: LGTM!The usage of the renamed
refetchAdminSpaceSubspacesPageQueryin therefetchQueriesoption is consistent with the change made in the import statement. Passing thespaceIdvariable to the query should ensure that the relevant subspaces data is fetched after a space deletion.
6-6: Verify the correctness of therefetchAdminSpaceSubspacesPageQueryquery.The renaming from
refetchAdminSpaceChallengesPageQuerytorefetchAdminSpaceSubspacesPageQueryaligns with the shift from challenges to subspaces. Please ensure that therefetchAdminSpaceSubspacesPageQueryquery is defined correctly and returns the expected data after a space deletion.Verification successful
Verification successful:
refetchAdminSpaceSubspacesPageQueryis correctly defined and used.The
refetchAdminSpaceSubspacesPageQueryis properly defined in the generated Apollo hooks file and consistently used across multiple components. It takes aspaceIdparameter as expected and is used to refetch data after relevant mutations, which is a good practice for maintaining UI consistency. The renaming from challenges to subspaces is applied consistently throughout the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `refetchAdminSpaceSubspacesPageQuery` query returns the expected data. # Test: Search for the query definition. Expect: The query to be defined and return subspaces data. rg --type typescript --type graphql -A 10 $'refetchAdminSpaceSubspacesPageQuery'Length of output: 114
Script:
#!/bin/bash # Description: Search for the definition of refetchAdminSpaceSubspacesPageQuery # Search in TypeScript files echo "Searching in TypeScript files:" fd -e ts -e tsx | xargs grep -n "refetchAdminSpaceSubspacesPageQuery" -A 10 # Search in GraphQL files echo "Searching in GraphQL files:" fd -e graphql -e gql | xargs grep -n "refetchAdminSpaceSubspacesPageQuery" -A 10Length of output: 11014
src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (2)
360-360: Clarify the intent behind the changes to theGutterscomponent.The changes involve removing the
disableGapprop and adding thedisablePaddingprop. These modifications will impact the spacing and layout of the child elements withinGutters.Please provide clarification on the following:
- Are these changes intentional and align with the design requirements?
- What is the expected behavior and visual outcome after these changes?
367-367: Clarify the intent behind adding thesizeprop to theJourneyCardHorizontalcomponent.The
sizeprop with a value of "medium" has been added to theJourneyCardHorizontalcomponent. This suggests that the component now supports different sizes, and setting the size to "medium" will likely adjust its dimensions and styling.Please provide clarification on the following:
- Is this change intentional and aligns with the design requirements?
- What is the expected visual appearance of the
JourneyCardHorizontalcomponent with the "medium" size?src/core/i18n/en/translation.en.json (2)
1868-1868: Looks good!The new
"licenseUpdated"key and its corresponding value make sense in the"account"section context. The message is clear.
1888-1900: The new"verification"section looks good!The nested keys under
"verification.confirm"provide the necessary translations for the organization verification confirmation dialog - including dynamic placeholders for the organization name, action (verify/unverify) and status. The structure and values seem appropriate.src/core/apollo/generated/apollo-helpers.ts (4)
2219-2219: LGTM!The addition of the
subscriptionsproperty to theOrganizationKeySpecifiertype is a valid change to recognize subscriptions as an attribute of an organization in the Apollo client configuration.
2245-2245: Looks good!Adding the
subscriptionsproperty to theOrganizationFieldPolicytype correctly allows for defining field policies or read functions for the newly introducedsubscriptionsattribute of an organization.
2250-2254: Great addition!The introduction of the
OrganizationSubscriptionKeySpecifierandOrganizationSubscriptionFieldPolicytypes is a valuable enhancement to the Apollo client configuration for organizations. These types provide type safety and extensibility for managing organization subscriptions by:
- Defining the keys that can be used to specify subscriptions (
expiresandname) through theOrganizationSubscriptionKeySpecifiertype.- Allowing for the definition of field policies for the subscription attributes (
expiresandname) through theOrganizationSubscriptionFieldPolicytype.The syntax and structure of these new types are correct and well-placed within the file.
4048-4051: Excellent update!The addition of the
OrganizationSubscriptionentry to theStrictTypedTypePoliciestype is a perfect complement to the previously introducedOrganizationSubscriptionKeySpecifierandOrganizationSubscriptionFieldPolicytypes. This change:
- Mirrors the structure of other organization-related types in the
StrictTypedTypePoliciestype.- Allows for custom key fields and field policies specific to
OrganizationSubscription.- Enhances the type safety and extensibility of the Apollo client configuration for organizations, particularly in relation to subscription management.
The syntax and placement of this change are correct and consistent with the rest of the file.
src/core/apollo/generated/apollo-hooks.ts (6)
12258-12310: LGTM!The
AssignLicensePlanToAccountmutation and its correspondinguseAssignLicensePlanToAccountMutationhook are generated correctly based on the provided GraphQL schema. The JSDoc comment provides clear usage instructions.
12311-12363: LGTM!The
RevokeLicensePlanFromAccountmutation and its correspondinguseRevokeLicensePlanFromAccountMutationhook are generated correctly based on the provided GraphQL schema. The JSDoc comment provides clear usage instructions.
12374-12400: LGTM!The modifications to the
adminGlobalOrganizationsListquery are syntactically correct and follow the GraphQL schema. The added fields provide more comprehensive information about organizations, their verification status, subscriptions, and licensing details, aligning with the requirements mentioned in the PR summary.
12463-12578: LGTM!The
AccountOnOrganizationquery and its corresponding hooks, as well as theadminOrganizationVerifymutation and its hook, are generated correctly based on the provided GraphQL schema. The JSDoc comments provide clear usage instructions. TheadminOrganizationVerifymutation aligns with the requirements mentioned in the PR summary for handling organization verification events.
Line range hint
18308-18320: LGTM!The renaming of the
AdminSpaceChallengesPagequery toAdminSpaceSubspacesPagealigns with the overall renaming effort mentioned in the PR summary. The addition of thecardBannerfield provides the visual URI for each subspace's card representation. The changes are syntactically correct and follow the GraphQL schema.
18338-18391: LGTM!The updates to the
useAdminSpaceChallengesPageQueryhook, its corresponding lazy query hook, associated types, and refetch function are consistent with the query renaming. The changes are syntactically correct, maintain the functionality of the hooks, and the JSDoc comment is updated accordingly.src/core/apollo/generated/graphql-schema.ts (6)
4178-4179: LGTM!The addition of the
subscriptionsfield to theOrganizationtype is a valuable enhancement for managing subscription details associated with organizations.
4214-4220: Looks good!The
OrganizationSubscriptiontype is well-defined with fields for tracking subscription expiry and name. This addition aligns with the goal of enhancing subscription management capabilities in the schema.
17732-17752: Great addition!The introduction of the
AssignLicensePlanToAccountMutationandRevokeLicensePlanFromAccountMutationmutation types, along with their respective variable types, enables the functionality for managing the assignment and revocation of license plans to accounts. This is a valuable enhancement to the licensing management capabilities of the system.
17768-17773: Excellent update!The inclusion of the
subscriptionsfield and the additional organization verification lifecycle details in theAdminGlobalOrganizationsListQueryenhances the information available to administrators. This change aligns with the goal of improving subscription management and providing more comprehensive organization data.
17782-17827: Solid enhancements!The introduction of the
licensingfield in theplatformquery, along with the new query typesAccountOnOrganizationQueryandAdminOrganizationVerifyMutation, significantly improves the schema's capabilities. These changes enable better management of licensing, querying of organization-related data, and performing administrative tasks such as organization verification. Well done!
23365-23383: Nice update!The renaming of the
AdminSpaceChallengesPageQuerytoAdminSpaceSubspacesPageQueryaligns with the shift from challenges to subspaces. The expanded profile structure within subspaces, including the optionalcardBannerfield, allows for richer profile representations. These changes improve the data representation and consistency with the subspaces concept.
src/domain/platform/admin/opportunity/pages/OpportunityList.tsx
Outdated
Show resolved
Hide resolved
The base branch was changed.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (3)
45-54: Update the avatar URL.The updated data structure for subspaces looks good. However, the
profile.avatar.uriis currently an empty string. If the actual avatar URL is available, please update it accordingly.
116-141: Implement the missing functionality.The event handlers for delete, duplicate, and save as template actions are implemented correctly. However, the actual implementation for duplicate and save as template is currently missing and marked as "todo". Please ensure to implement these features.
Do you want me to open a GitHub issue to track the implementation of the duplicate and save as template features?
143-159: Disable the incomplete menu items.The
getActionsfunction correctly generates the action menu items for each subspace. However, since the duplicate and save as template functionality is not yet implemented, it would be better to disable those menu items until they are fully functional to avoid confusion for the users.Apply this diff to disable the incomplete menu items:
-<MenuItemWithIcon disabled={false} iconComponent={ContentCopyOutlined} onClick={() => onDuplicateClick(item)}> +<MenuItemWithIcon disabled={true} iconComponent={ContentCopyOutlined} onClick={() => onDuplicateClick(item)}> Duplicate Subspace </MenuItemWithIcon> -<MenuItemWithIcon disabled={false} iconComponent={DownloadForOfflineOutlined} onClick={() => onSaveAsTemplateClick(item)}> +<MenuItemWithIcon disabled={true} iconComponent={DownloadForOfflineOutlined} onClick={() => onSaveAsTemplateClick(item)}> Save As Template </MenuItemWithIcon>src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (1)
164-172: TODO: Implement duplicate and save as template features.The event handlers for duplicating a subspace and saving a subspace as a template are defined, but the actual implementation is not yet complete. There are TODO comments indicating that these features need to be implemented.
Consider creating separate GitHub issues to track the implementation of these features and ensure they are addressed in future updates.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- src/core/apollo/generated/apollo-hooks.ts (3 hunks)
- src/core/apollo/generated/graphql-schema.ts (1 hunks)
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (1 hunks)
- src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx (4 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/AdminChallengesPage.graphql (2 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (7 hunks)
- src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfileView.tsx (2 hunks)
- src/domain/platform/admin/components/SearchableList.tsx (4 hunks)
- src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (5 hunks)
- src/domain/shared/icons/profileIcons.ts (2 hunks)
Files skipped from review as they are similar to previous changes (6)
- src/core/apollo/generated/apollo-hooks.ts
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx
- src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx
- src/domain/journey/space/pages/SpaceSubspaces/AdminChallengesPage.graphql
- src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfileView.tsx
- src/domain/shared/icons/profileIcons.ts
Additional comments not posted (16)
src/domain/platform/admin/components/SearchableList.tsx (5)
1-8: LGTM!The new imports are necessary for the component's functionality and there are no issues with them.
17-18: The new props align with the PR objectives.The addition of the
journeyTypeNameandgetActionsprops aligns with the PR objectives of transitioning from challenges to subspaces and enhancing the actions menu for each item. The changes provide more flexibility in specifying the journey type and rendering actions.
26-40: The updatedSearchableListIteminterface enhances the item structure.The changes to the
SearchableListIteminterface, introducing aprofileobject with properties likedisplayName,url,tagline,avatar, andcardBanner, provide a more structured representation of each list item. This aligns with the PR objective of enhancing the visual representation of items using theJourneyCardHorizontalcomponent.
Line range hint
49-63: The changes align with the component's refactoring and PR objectives.The destructuring of
journeyTypeNameandgetActionsprops, along with the modified filtering logic to search through thedisplayNamewithin theprofileobject, aligns with the component's usage and the PR objectives. The changes are consistent with the overall refactoring of the component to support the transition from challenges to subspaces.
79-101: The updated rendering logic enhances the visual representation and flexibility.The changes to the rendering logic, including the updated loading state with multiple
LoadingListItemcomponents and the transition fromListItemLinktoJourneyCardHorizontal, enhance the visual representation of the list and its items. The usage ofJourneyCardHorizontalwith various props allows for customization of the item's appearance and behavior, while the conditional rendering of actions using thegetActionsprop provides flexibility in defining item-specific actions. These changes align with the PR objectives of improving the user interface and experience.src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (3)
24-26: LGTM!The imports are consistent with the file path and naming conventions. The imported entities are likely used in the component for implementing new features.
37-38: LGTM!The state variables are initialized with appropriate default values and the naming is clear and descriptive. They are used to manage the delete confirmation dialog and track the selected item for deletion.
Line range hint
174-193: LGTM!The component rendering has been updated to include the new features. The
SearchableListis properly wrapped inside theGutterscomponent and provided with the necessary props. TheEntityConfirmDeleteDialogis added and configured correctly to handle the delete confirmation flow. The rendering logic looks good.src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (7)
9-14: LGTM!The imports have been appropriately renamed to reflect the transition from challenges to subspaces. The imported hooks are necessary for the component to interact with the GraphQL API for subspace-related operations.
18-21: LGTM!The imported
SubspaceIconandCreateSubspaceFormcomponents are consistent with the transition from challenges to subspaces. These components are likely used in the UI for subspace-related functionality.
28-33: LGTM!The imported UI components are likely used to enhance the user interface and interactions related to subspaces. The
EntityConfirmDeleteDialogcomponent is a new addition, likely used to confirm the deletion of a subspace.
35-72: LGTM!The
SubspaceListViewcomponent has been appropriately refactored to handle subspaces instead of challenges. TheuseAdminSpaceSubspacesPageQueryhook is used to fetch subspace data, and the fetched data is mapped to the expected structure. TheuseDeleteSpaceMutationhook is used for deleting subspaces, with appropriate refetching and notification handling.
Line range hint
80-90: LGTM!The
handleDeletefunction is responsible for deleting a subspace using thedeleteSubspacemutation. It takes an object with anidproperty as a parameter to identify the subspace to be deleted. The implementation is straightforward and consistent with the overall subspace deletion functionality.
Line range hint
90-127: LGTM!The
handleCreatefunction is responsible for creating a new subspace using thecreateSubspacemutation. It takes aJourneyFormValuesobject as a parameter, which contains the form values for creating a new subspace. If the creation is successful, it navigates to the settings URL of the newly created subspace using thenavigatefunction. The implementation is consistent with the overall subspace creation functionality.
Line range hint
147-258: LGTM!The code segment defines several event handlers and rendering logic for the
SubspaceListViewcomponent. The overall structure and functionality are consistent with the subspace management requirements.The
SearchableListcomponent is used to render the list of subspaces, and thegetSubSpaceActionsfunction provides the actions for each subspace item. TheJourneyCreationDialog,SelectDefaultInnovationFlowDialog, andEntityConfirmDeleteDialogcomponents are used for creating a new subspace, selecting a default innovation flow, and confirming the deletion of a subspace, respectively.src/core/apollo/generated/graphql-schema.ts (1)
21918-21936: LGTM! The changes enhance the schema for subspace management and profile representation.The code segment introduces the following key changes:
The
AdminSpaceChallengesPageQueryhas been renamed toAdminSpaceSubspacesPageQuery, reflecting the shift in focus from challenges to subspaces within a space.The
AdminSpaceSubspacesPageQueryVariablestype has been introduced, requiring aspaceIdof typeUUID_NAMEID. This ensures that the query is specific to a particular space.The structure of the
subspacesarray within thespaceobject has been enhanced to include an optionalcardBannerfield in theprofileobject of each subspace. This allows for the inclusion of visual elements associated with profiles, enriching the data representation for subspaces.These changes are consistent with the provided AI-generated summary and the list of alterations, and they contribute to a better organization of the schema for subspace management and enhanced profile representation.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (3)
45-54: Populate the avatar property with actual data.The updated subsubspaces data structure looks good. It now includes additional properties such as id, profile with displayName, url, and avatar. However, the avatar property is currently set to an empty string. Consider populating it with actual avatar data to enhance the user experience.
133-141: Reminder: Implement the duplicate and save as template functionality.The new onDuplicateClick and onSaveAsTemplateClick functions are placeholders for the duplicate and save as template functionality. Please ensure to implement the required logic for these features.
Do you want me to generate the code for the duplicate and save as template functionality or open a GitHub issue to track these tasks?
143-155: Enable the duplicate and save as template actions once implemented.The new getActions function provides a clean and structured way to define the action buttons for each subspace. The duplicate and save as template actions are currently disabled, which is appropriate given the pending implementation. Once the functionality is ready, remember to enable these actions by removing the disabled prop.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (7 hunks)
- src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (5 hunks)
Additional comments not posted (20)
src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (6)
24-26: LGTM!The new imports for icons and components are relevant to the changes made in the file. They follow the proper naming conventions and syntax.
37-38: LGTM!The new state variables for managing the delete dialog and selected item are correctly typed and initialized. They are used appropriately in the subsequent code changes.
116-119: LGTM!The new onDeleteClick function correctly handles the delete button click by setting the deleteDialogOpen state to true and the selectedItem state to the passed item. It is used appropriately as a callback in the subsequent code changes.
121-124: LGTM!The new clearDeleteState function correctly resets the delete dialog state by setting the deleteDialogOpen state to false and the selectedItem state to undefined. It is used appropriately as a callback for the delete dialog close event in the subsequent code changes.
126-131: LGTM!The new onDeleteConfirmation function correctly handles the delete confirmation by checking if selectedItem exists, calling the handleDelete function with selectedItem as a parameter, and setting the deleteDialogOpen state to false. It is used appropriately as a callback for the delete confirmation event in the subsequent code changes.
Line range hint
170-189: LGTM!The updated rendering logic looks good:
- The Gutters component is used effectively to provide consistent spacing and improve the layout.
- The getActions function is correctly passed as a prop to the SearchableList component, enabling action buttons for each subspace.
- The EntityConfirmDeleteDialog component is properly integrated to display a confirmation dialog when deleting a subspace.
- The delete dialog state and callbacks are correctly wired up with the EntityConfirmDeleteDialog component.
src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (14)
9-10: LGTM!The imports have been updated to use the subspace-related queries, which aligns with the overall refactor.
18-18: LGTM!The import has been updated to use the
SubspaceIcon, which aligns with the overall refactor.
21-21: LGTM!The new import for
CreateSubspaceFormhas been added, which will be used to handle the creation of subspaces.
28-28: LGTM!The new imports for various icons have been added, which will likely be used for actions related to subspaces.
30-33: LGTM!The new imports for various components have been added, which will be used in the
SubspaceListViewcomponent for the UI layout, menu items, displaying the list of subspaces, and the delete confirmation dialog.
35-35: LGTM!The component has been renamed from
ChallengeListViewtoSubspaceListView, which aligns with the overall refactor.
43-43: LGTM!The query has been renamed from
useAdminSpaceChallengesPageQuerytouseAdminSpaceSubspacesPageQuery, which aligns with the overall refactor.
51-53: LGTM!The new state variables
deleteDialogOpenandselectedItemhave been introduced, which will be used for implementing the delete confirmation dialog and tracking the selected item for deletion.
58-69: LGTM!The subspace data has been mapped to a new structure that includes the necessary properties for displaying the list of subspaces, including the subspace avatar using the
profile.cardBanner?.uri.
70-78: LGTM!The mutation has been renamed from
useDeleteSpaceMutationtouseDeleteSubspaceMutation, and therefetchQueriesoption and success notification message have been updated to align with the subspace context.
Line range hint
80-88: LGTM!The
handleDeletefunction has been implemented to delete a subspace based on the provideditem.idusing thedeleteSubspacemutation.
90-96: LGTM!The mutation has been renamed from
useCreateSubspaceMutationtouseCreateSubspaceMutation, and theonCompletedcallback andrefetchQueriesoption have been updated to align with the subspace context.
Line range hint
100-126: LGTM!The
handleCreatefunction has been updated to use thecreateSubspacemutation with the necessary input variables for creating a subspace. The navigation logic has also been updated to navigate to the settings URL of the created subspace.
Line range hint
127-254: Verify the remaining code changes.The remaining code changes include:
- Updates to the
updateInnovationFlowmutation and related logic.- Implementation of the delete confirmation dialog and related functions.
- Implementation of placeholder functions for duplicate and save as template actions.
- Updates to the UI components and layout to align with the subspace context.
Please ensure that these changes are thoroughly tested and verified to work as expected.
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range and nitpick comments (1)
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx (1)
36-38: Remove empty TableCell in TableHead to improve accessibilityIncluding an empty
<TableCell>in the header row can confuse assistive technologies and does not provide meaningful information.Consider removing the empty
<TableCell>or providing a relevant header if additional columns are intended.Proposed change:
- <TableCell component="th" scope="row" sx={{ flex: 1 }}> - - </TableCell>
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- src/core/apollo/generated/apollo-hooks.ts (3 hunks)
- src/core/apollo/generated/graphql-schema.ts (3 hunks)
- src/domain/community/contributor/organization/adminOrganizations/adminGlobalOrganizationsList.graphql (1 hunks)
- src/domain/community/contributor/organization/adminOrganizations/useAdminGlobalOrganizationsList.ts (1 hunks)
- src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx (4 hunks)
- src/domain/community/user/adminUsers/userList.graphql (1 hunks)
- src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (4 hunks)
- src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx (1 hunks)
- src/domain/shared/components/SearchableList/SimpleSearchableTable.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (4)
- src/domain/community/contributor/organization/adminOrganizations/adminGlobalOrganizationsList.graphql
- src/domain/community/contributor/organization/adminOrganizations/useAdminGlobalOrganizationsList.ts
- src/domain/community/user/adminUsers/useAdminGlobalUserList.tsx
- src/domain/shared/components/SearchableList/SimpleSearchableTable.tsx
Additional context used
Biome
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx
[error] 65-65: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
Additional comments not posted (14)
src/domain/community/user/adminUsers/userList.graphql (1)
15-18: LGTM!The addition of the
visualfield to theuserListquery is a valid enhancement. It allows for retrieving the avatar information associated with users, which can be used to improve the user interface.The field is correctly typed as
AVATARand includes the necessary subfieldsidanduri. The change is well-contained within theprofilefield and does not affect other parts of the query.Please ensure that the GraphQL schema on the server side supports the new
visualfield for the query to execute successfully.src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (5)
4-13: LGTM!The imports from
@mui/materialare necessary for the component implementation.
17-17: LGTM!The import of
RouterLinkandRouterLinkPropsis necessary for the component implementation.
27-27: LGTM!The import of
Sizeis necessary for the component implementation.
58-58: LGTM!The addition of the optional
sizeproperty to theJourneyCardHorizontalPropsinterface enhances the flexibility of theJourneyAvatarcomponent rendering.
Line range hint
76-94: LGTM!The changes to the
JourneyCardHorizontalcomponent improve its configurability and visual consistency by:
- Utilizing the new
sizeprop to pass to theJourneyAvatarcomponent, replacing the previous hardcoded dimensions.- Setting the
borderRadiusstyle to 'unset' to influence the visual styling of the card.src/core/apollo/generated/apollo-hooks.ts (3)
11576-11579: LGTM!The addition of the
visual(type: AVATAR)field to theAdminGlobalOrganizationsListDocumentquery enhances the data structure by allowing the retrieval of avatar visuals for organizations. Theidandurifields provide the necessary data to display the avatars in the user interface.
12928-12931: LGTM!The addition of the
visual(type: AVATAR)field to theUserListDocumentquery enhances the data structure by allowing the retrieval of avatar visuals for users. Theidandurifields provide the necessary data to display the avatars in the user interface.
17800-17942: LGTM!The introduction of the
AdminSpaceSubspacesPagequery and the associated renaming of hooks and types align with the overall refactoring effort to transition from challenges to subspaces. The new query structure provides a more comprehensive data set for subspaces, including the card banner visual and default innovation flow template.The addition of the
cardBanner: visual(type: CARD)field enhances the visual data available for subspaces, allowing for improved display in the user interface.The changes maintain consistency and clarity in the codebase and do not introduce any apparent issues or breaking changes.
src/core/apollo/generated/graphql-schema.ts (3)
16312-16318: LGTM!The addition of the optional
visualfield to theprofiletype allows for including visual representations associated with profiles while maintaining backward compatibility.
17173-17179: LGTM!The changes are identical to the previous code segment and are consistent across both query types.
22313-22403: LGTM!The introduction of the
AdminSpaceSubspacesPageQueryquery type and the associated changes to the schema reflect a well-structured reorganization to better accommodate subspace management. The addition of thecardBannerfield enhances the representation of profiles within subspaces, while the retention of theUpdateSpaceDefaultInnovationFlowTemplateMutationensures that the existing mutation functionality remains intact.The changes are consistent with the provided list of alterations and contribute to an improved GraphQL schema for managing subspaces.
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx (2)
6-6: Imports updated correctlyThe
BlockTitleandCardTitlecomponents are imported correctly from the typography module.
11-11: Material-UI components imported properlyThe necessary Material-UI components are imported appropriately.
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Outdated
Show resolved
Hide resolved
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Show resolved
Hide resolved
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Outdated
Show resolved
Hide resolved
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Outdated
Show resolved
Hide resolved
src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (2)
58-59: LGTM: New properties enhance component flexibility.The addition of 'size' and 'whitHoverState' properties to the JourneyCardHorizontalProps interface improves the component's customization options. This allows for more flexible usage in different contexts.
Consider adding JSDoc comments to these new properties to improve code documentation:
/** Size of the JourneyAvatar */ size?: Size; /** Whether to apply hover state styling */ whitHoverState?: boolean;
89-89: LGTM: Component implementation updated correctly.The changes to the JourneyCardHorizontal component implementation improve its flexibility and customization options:
- The 'size' prop is correctly passed to JourneyAvatar.
- The Wrapper component is conditionally used based on 'whitHoverState'.
Consider adding a comment explaining the reason for setting 'borderRadius' to 'unset', as this might affect the visual styling:
borderRadius: 'unset', // Removed border radius to match design specificationsAlso applies to: 96-97
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
src/core/apollo/generated/apollo-hooks.tsis excluded by!**/generated/**src/core/apollo/generated/graphql-schema.tsis excluded by!**/generated/**
Files selected for processing (3)
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (1 hunks)
- src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (4 hunks)
- src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx
- src/domain/platform/admin/virtual-contributors/VirtualContributorsPage.tsx
Additional context used
Biome
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx
[error] 66-66: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
Additional comments not posted (2)
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (2)
4-13: LGTM: New imports are correctly added.The new imports from '@mui/material', RouterLink, RouterLinkProps, and Size are necessary for the changes made in the component. They are correctly imported and will be used in the updated implementation.
Also applies to: 17-17, 27-27
77-78: LGTM: New props correctly implemented.The 'size' and 'whitHoverState' props have been correctly added to the JourneyCardHorizontal component, matching the interface changes. The default value for 'whitHoverState' ensures backward compatibility.
src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (9)
src/domain/journey/space/pages/SpaceSettings/EntityConfirmDeleteDialog.tsx (1)
34-37: LGTM: Excellent handling of asynchronous delete operation.The implementation of
handleDeleteusinguseLoadingStateis well done. It properly manages the asynchronous nature of the delete operation and provides a way to handle loading state, which is crucial for good user experience.One minor suggestion for improvement:
Consider calling
handleCloseafter successful deletion to automatically close the dialog. This could be implemented as follows:const [handleDelete, loading] = useLoadingState(async () => { await onDelete(); setChecked(false); + handleClose(); });This change would provide a smoother user experience by automatically closing the dialog after a successful delete operation.
src/domain/platform/admin/opportunity/pages/OpportunitySettings/OpportunitySettingsView.tsx (2)
35-35: Consider preserving loading state for better UXThe removal of the
loadingstate from theuseDeleteSpaceMutationhook might impact the user experience. Without this state, there may be no visual feedback to the user during the deletion process.Consider keeping the
loadingstate and using it to show a loading indicator:-const [deleteOpportunity] = useDeleteSpaceMutation({ +const [deleteOpportunity, { loading }] = useDeleteSpaceMutation({Then, pass the
loadingstate to theEntityConfirmDeleteDialogcomponent to display a loading indicator during deletion.
Line range hint
60-66: Approved: Improved error handling opportunityThe change to return the result of
deleteOpportunityfromhandleDeleteis a good improvement. It allows the caller to handle the Promise returned by the mutation.Consider adding error handling to improve robustness:
const handleDelete = () => { - return deleteOpportunity({ + return deleteOpportunity({ variables: { input: { ID: subspaceId, }, }, - }); + }).catch(error => { + notify(t('pages.admin.space.notifications.space-remove-error'), 'error'); + console.error('Error deleting subspace:', error); + }); };This will ensure that any errors during deletion are properly caught and communicated to the user.
src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (6)
Line range hint
1-35: Remove unused imports and approve changes.The refactoring from challenges to subspaces looks good. However, there are some imports that appear to be unused:
InnovationFlowProfileView(line 25)InnovationFlowStates(line 26)Consider removing these imports if they are not used elsewhere in the file.
35-67: Approve query changes and suggest error handling improvement.The update to use
useAdminSpaceSubspacesPageQueryand the new state management for deletion look good. However, there's a minor improvement that could be made in error handling:On line 50, consider adding a fallback for when
data?.space.defaults?.idis undefined:const spaceDefaultsID = data?.space.defaults?.id ?? '';This ensures that even if the ID is undefined, an empty string will be used instead of undefined.
Line range hint
70-89: Approve delete mutation and suggest error handling improvement.The update to use
useDeleteSpaceMutationand the newhandleDeletefunction look good. However, consider adding error handling to thehandleDeletefunction:const handleDelete = async (item: { id: string }) => { try { await deleteSubspace({ variables: { input: { ID: item.id, }, }, }); } catch (error) { console.error('Error deleting subspace:', error); notify(t('pages.admin.subspace.notifications.subspace-delete-error'), 'error'); } };This will catch any errors during the deletion process and notify the user if something goes wrong.
Line range hint
90-127: Approve create mutation and suggest error handling improvement.The update to use
useCreateSubspaceMutationand the changes to thehandleCreatefunction look good. However, consider adding more robust error handling:const handleCreate = useCallback( async (value: JourneyFormValues) => { try { const { data } = await createSubspace({ variables: { input: { spaceID: spaceNameId, profileData: { displayName: value.displayName, description: value.background, tagline: value.tagline, }, context: { vision: value.vision, }, tags: value.tags, collaborationData: { addDefaultCallouts: value.addDefaultCallouts, }, }, }, }); if (!data?.createSubspace) { throw new Error('Failed to create subspace'); } if (data.createSubspace.profile.url) { navigate(buildSettingsUrl(data.createSubspace.profile.url)); } } catch (error) { console.error('Error creating subspace:', error); notify(t('pages.admin.subspace.notifications.subspace-creation-error'), 'error'); } }, [navigate, createSubspace, spaceNameId, notify, t] );This will provide better error handling and user feedback in case of creation failures.
147-186: Approve new action handlers and suggest TODOs for unimplemented features.The new action handlers and menu items for delete, duplicate, and save as template are good additions. However, the duplicate and save as template functionalities are not implemented yet. Consider adding more descriptive TODO comments:
const onDuplicateClick = (item: SearchableListItem) => { // TODO: Implement subspace duplication functionality // This should create a new subspace with the same properties as the selected one setSelectedItem(item); }; const onSaveAsTemplateClick = (item: SearchableListItem) => { // TODO: Implement save as template functionality // This should create a new template based on the selected subspace setSelectedItem(item); };Also, consider adding a TODO comment in the
getSubSpaceActionsfunction to remind about enabling these features once implemented:<MenuItemWithIcon disabled iconComponent={ContentCopyOutlined} onClick={() => onDuplicateClick(item)}> Duplicate Subspace </MenuItemWithIcon> {/* TODO: Enable once duplication is implemented */} <MenuItemWithIcon disabled iconComponent={DownloadForOfflineOutlined} onClick={() => onSaveAsTemplateClick(item)}> Save As Template </MenuItemWithIcon> {/* TODO: Enable once save as template is implemented */}These comments will help track the pending implementations and remind developers to enable the menu items once the features are ready.
Line range hint
188-252: Approve component rendering changes and suggest minor improvement.The updates to the component rendering to reflect the change from challenges to subspaces look good. The addition of the
EntityConfirmDeleteDialogfor subspace deletion confirmation is a good practice.Consider adding more context to the delete confirmation dialog by including the name of the subspace being deleted:
<EntityConfirmDeleteDialog entity={t('common.subspace')} entityName={selectedItem?.profile.displayName} open={deleteDialogOpen} onClose={clearDeleteState} onDelete={onDeleteConfirmation} description={'components.deleteEntity.confirmDialog.descriptionShort'} />This will provide users with more information about which subspace they are about to delete, reducing the chance of accidental deletions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (10)
- src/core/ui/avatar/Avatar.tsx (1 hunks)
- src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (6 hunks)
- src/domain/journey/common/JourneyAvatar/JourneyAvatar.tsx (1 hunks)
- src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx (4 hunks)
- src/domain/journey/space/pages/SpaceAccount/SpaceAccountView.tsx (2 hunks)
- src/domain/journey/space/pages/SpaceSettings/EntityConfirmDeleteDialog.tsx (3 hunks)
- src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (3 hunks)
- src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (7 hunks)
- src/domain/platform/admin/opportunity/pages/OpportunityList.tsx (6 hunks)
- src/domain/platform/admin/opportunity/pages/OpportunitySettings/OpportunitySettingsView.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
- src/core/ui/avatar/Avatar.tsx
- src/domain/journey/common/JourneyAvatar/JourneyAvatar.tsx
- src/domain/journey/common/JourneyCardHorizontal/JourneyCardHorizontal.tsx
- src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx
- src/domain/platform/admin/opportunity/pages/OpportunityList.tsx
🧰 Additional context used
Biome
src/domain/journey/space/pages/SpaceSettings/EntityConfirmDeleteDialog.tsx
[error] 18-18: void is confusing inside a union type.
Unsafe fix: Use undefined instead.
(lint/suspicious/noConfusingVoidType)
🔇 Additional comments not posted (11)
src/domain/journey/space/pages/SpaceSettings/EntityConfirmDeleteDialog.tsx (4)
11-11: LGTM: Good use of a custom hook for loading state management.The addition of
useLoadingStateis a positive change. It suggests the implementation of a reusable solution for managing loading states, which can improve code consistency and maintainability across the application.
30-33: LGTM: Good encapsulation of dialog closing logic.The
handleClosefunction is a well-structured addition. It properly encapsulates the logic for closing the dialog and resetting its state, which is a good practice for maintaining clean and readable code.
40-43: LGTM: Excellent integration of new functionality with UI components.The changes in the component's JSX effectively integrate the new
handleCloseandhandleDeletefunctions:
- Using
handleClosefor the Dialog'sonCloseprop ensures consistent behavior when closing the dialog.- The LoadingButton now correctly uses the
loadingstate fromhandleDelete, providing proper visual feedback during the asynchronous delete operation.- Updating the LoadingButton's
onClickhandler to usehandleDeleteties everything together, ensuring the new asynchronous delete logic is triggered when the button is clicked.These changes demonstrate a good understanding of React patterns and state management.
Also applies to: 56-61
18-18: LGTM: Improved flexibility for delete operations.The change to
() => Promise<unknown> | voidis a good improvement. It allows for both synchronous and asynchronous delete operations, making the component more versatile.Regarding the static analysis hint:
While the static analysis tool suggests using
undefinedinstead ofvoidin a union type, in this case,voidis more appropriate. It correctly represents the absence of a return value for synchronous operations. The current implementation is correct and doesn't need to be changed.To verify the usage of this prop type across the codebase, we can run the following script:
This script will help identify any inconsistencies in how the
onDeleteprop is declared or used across the codebase, ensuring that the new type is consistently applied.✅ Verification successful
LGTM: Improved flexibility for delete operations.
The change to
() => Promise<unknown> | voidis a good improvement. It allows for both synchronous and asynchronous delete operations, making the component more versatile.Regarding the static analysis hint:
- Approved
No inconsistencies were found in the usage of the
onDeleteprop across the codebase. Existing implementations remain compatible with the updated prop type.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for inconsistencies in onDelete prop usage # Search for onDelete prop declarations echo "onDelete prop declarations:" rg --type typescript "onDelete\s*:\s*\(\)\s*=>\s*(Promise<unknown>\s*\|\s*void|void\s*\|\s*Promise<unknown>)" -g '!**/EntityConfirmDeleteDialog.tsx' # Search for onDelete prop usages echo "\nonDelete prop usages:" rg --type typescript "onDelete\s*=\s*\{.*\}" -g '!**/EntityConfirmDeleteDialog.tsx'Length of output: 428
Script:
#!/bin/bash # Description: Check for inconsistencies in onDelete prop usage # Search for onDelete prop declarations in .ts and .tsx files echo "onDelete prop declarations:" rg "onDelete\s*:\s*\(\)\s*=>\s*(Promise<unknown>\s*\|\s*void|void\s*\|\s*Promise<unknown>)" --glob '!**/EntityConfirmDeleteDialog.tsx' --type-add 'typescript:*.ts,*.tsx' --type typescript # Search for onDelete prop usages in .ts and .tsx files echo "\nonDelete prop usages:" rg "onDelete\s*=\s*\{.*\}" --glob '!**/EntityConfirmDeleteDialog.tsx' --type-add 'typescript:*.ts,*.tsx' --type typescriptLength of output: 734
Script:
#!/bin/bash # Description: Check for inconsistencies in onDelete prop usage by explicitly targeting .ts and .tsx files # Search for onDelete prop declarations in .ts and .tsx files echo "onDelete prop declarations:" rg "onDelete\s*:\s*\(\)\s*=>\s*(Promise<unknown>\s*\|\s*void|void\s*\|\s*Promise<unknown>)" --glob '!**/EntityConfirmDeleteDialog.tsx' --glob '*.ts' --glob '*.tsx' # Search for onDelete prop usages in .ts and .tsx files echo "\nonDelete prop usages:" rg "onDelete\s*=\s*\{.*\}" --glob '!**/EntityConfirmDeleteDialog.tsx' --glob '*.ts' --glob '*.tsx'Length of output: 4423
🧰 Tools
Biome
[error] 18-18: void is confusing inside a union type.
Unsafe fix: Use undefined instead.
(lint/suspicious/noConfusingVoidType)
src/domain/journey/space/pages/SpaceSubspaces/SubspaceListView.tsx (1)
253-253: Approve export statement change.The update to export
SubspaceListViewinstead ofChallengeListViewis correct and consistent with the refactoring.src/domain/journey/space/pages/SpaceAccount/SpaceAccountView.tsx (2)
Line range hint
168-174: Approve changes to handleDelete and verify dialog behaviorThe changes to the
handleDeletefunction look good. Returning the result ofdeleteSpaceallows for better promise handling.However, please verify that the removal of the
submittingprop fromEntityConfirmDeleteDialogdoesn't negatively impact the user experience during the deletion process. Ensure that the dialog still provides appropriate feedback to the user while the deletion is in progress.#!/bin/bash # Check the implementation of EntityConfirmDeleteDialog to see if it handles loading state internally rg --type typescript 'const EntityConfirmDeleteDialog' src/
Line range hint
154-166: Verify the impact of removing the loading stateThe
loadingstate has been removed from theuseDeleteSpaceMutationhook. This might affect the UI's ability to show a loading indicator during the deletion process.Please confirm that the removal of the loading state doesn't negatively impact the user experience. If a loading indicator is still needed, consider using the mutation function's return value to manage the loading state.
✅ Verification successful
Loading state removal verified
The removal of the
loadingstate from theuseDeleteSpaceMutationhook does not adversely affect the UI's ability to display a loading indicator during the deletion process.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if there are any remaining references to a loading state for space deletion rg --type typescript 'loading.*delete.*space' src/Length of output: 96
Script:
#!/bin/bash # Check if there are any remaining references to a loading state for space deletion rg 'loading.*delete.*space' --glob '*.ts' --glob '*.tsx' src/Length of output: 63
src/domain/community/contributor/AccountTab/ContributorAccountView.tsx (4)
Line range hint
177-184: Improved mutation handling indeleteSpaceThe change to directly return the result of
deleteSpaceMutationis a good improvement. It makes the function more versatile by allowing the caller to handle the promise returned by the mutation if needed, while still maintaining the existing functionality.
Line range hint
206-213: Consistent improvement indeleteVCThe modification to directly return the result of
deleteVCMutationis consistent with the changes made to other deletion functions. This change enhances the function's flexibility and maintains a uniform pattern across the component.
Line range hint
235-241: Consistent mutation handling indeletePackThe change to directly return the result of
deletePackMutationfollows the same pattern as the other deletion functions. This consistent approach across all deletion functions in the component improves code readability and maintainability.
Line range hint
262-285: Improved mutation handling and simplifieddeleteEntity
The
deleteHubfunction now directly returns the result ofdeleteHubMutation, consistent with other deletion functions.The
deleteEntityfunction has been simplified:
- Removed unnecessary
breakstatements.- Each case now directly returns the result of the corresponding deletion function.
These changes improve code clarity and ensure that the results of the deletion functions are properly propagated. The consistent pattern across all deletion functions enhances maintainability.
* Subspace list created with JourneyCardHorizontal, challenge renamings * Subspace list - searchable, prep for admin list table * duplicate and save as template menu options * the new list + menu options for opportunities * disable the menu options that are not implemented yet * update admin tables with avatars, fix VC table * fix Account Tab layout --------- Co-authored-by: Carlos Cano <carlos@alkem.io>
* codegen updated + running * code in progress to update to new api * started moving RoleSet related code to separate folder; fixed additional compile errors * additional tidy up * additional tidy up * no compilation errors * moved myROles myMembership to be on RoleSet * fixed error with graphql file * updated for latest api * fixed last error; regenerate with latest from server * 0.72.0 * 0.72.1 * 0.72.2 * 0.72.3 * Client changes to accommodated server side master (#6868) * a helper sync-check * wip * wip * wip * fixed double connection * removed subscription, save button, redundant code * room-saved event handled * absolute code removed * code improvements * fixed ts issues * redundant type * removed scene_init update type * translation changed for last saved * addressed own comments --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Actions menu in Subspace List * (#6885) * Subspace list created with JourneyCardHorizontal, challenge renamings * Subspace list - searchable, prep for admin list table * duplicate and save as template menu options * the new list + menu options for opportunities * disable the menu options that are not implemented yet * update admin tables with avatars, fix VC table * fix Account Tab layout --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * fix merge * updated retrieval of community application form * fix picking up authorization from roleSet instead of community * additional fixes to get the right roleset ID; remove passing of community + rename entities * Fixes * fix build * a bit more refactor * entityDashboardRoleSet * Fix application button * Fixes * Fix roleSetId instead of communityId * Another communityId * small bugfix --------- Co-authored-by: bobbykolev <bobbykolev@abv.bg> Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io> Co-authored-by: Carlos Cano <carlos@alkem.io>
* codegen updated + running * code in progress to update to new api * started moving RoleSet related code to separate folder; fixed additional compile errors * additional tidy up * additional tidy up * no compilation errors * moved myROles myMembership to be on RoleSet * fixed error with graphql file * updated for latest api * fixed last error; regenerate with latest from server * 0.72.0 * 0.72.1 * 0.72.2 * 0.72.3 * Client changes to accommodated server side master (#6868) * a helper sync-check * wip * wip * wip * fixed double connection * removed subscription, save button, redundant code * room-saved event handled * absolute code removed * code improvements * fixed ts issues * redundant type * removed scene_init update type * translation changed for last saved * addressed own comments --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Actions menu in Subspace List * (#6885) * Subspace list created with JourneyCardHorizontal, challenge renamings * Subspace list - searchable, prep for admin list table * duplicate and save as template menu options * the new list + menu options for opportunities * disable the menu options that are not implemented yet * update admin tables with avatars, fix VC table * fix Account Tab layout --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * fix merge * updated retrieval of community application form * fix picking up authorization from roleSet instead of community * additional fixes to get the right roleset ID; remove passing of community + rename entities * Fixes * fix build * a bit more refactor * entityDashboardRoleSet * Fix application button * Fixes * Fix roleSetId instead of communityId * Another communityId * small bugfix --------- Co-authored-by: bobbykolev <bobbykolev@abv.bg> Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io> Co-authored-by: Carlos Cano <carlos@alkem.io>
As part of #6790
SearchableList.tsxwas replaced with a list of JourneyCardHorizontal (supporting actions menu);whitHoverStatewhich controls the Hover ListItem Wrapper (also fixing the layout in the Account Tab Page);EntityConfirmDeleteDialogdialog;@SimoneZaza approved the UI/UX changes above.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Style