Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geant4 recipe #2488

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Update geant4 recipe #2488

merged 2 commits into from
Sep 20, 2020

Conversation

ihrivnac
Copy link
Contributor

Restore back the Modulefile variables removed in previous commit
and keep modifications for data sets

Restore back the Modulefile variables removed in previous commit
and keep modifications for data sets
@ihrivnac
Copy link
Contributor Author

@ktf, there are added back all variables which I removed from module file in the last update. Let's try this first, and if it does not help, we can then revert the file to the previous version completely.

@ihrivnac
Copy link
Contributor Author

@ktf, the geant4 recipe is now as before, and the builds end with Geant4 installation, which passes ok (what was also the case before reverting the recipe), and the check is marked as failed.

@ihrivnac
Copy link
Contributor Author

@kft,
I investigated the guntest failure on CC7, which caused the AliRoot PR failures after merging this PR, and the problems seems to be in aliBuild interpretation of the sed command used to defined the G4 data sets variables.
While in the recipe, there is:

G4ABLADATA : "${G4INSTALL}/bin/geant4-config --datasets | grep G4ABLADATA | sed 's/[^ ]* [^ ]* //'"
The aliBuild adds''around spaces:

DEBUG:AliRoot-guntest:AliRoot-guntest:0: +++++ /root/alice/sw/slc7_x86-64/GEANT4/v10.5.1-3/bin/geant4-config --datasets
DEBUG:AliRoot-guntest:AliRoot-guntest:0: +++++ grep G4ABLADATA
DEBUG:AliRoot-guntest:AliRoot-guntest:0: +++++ sed 's/[^' ']*' '[^' ']*' //
DEBUG:AliRoot-guntest:AliRoot-guntest:0: sed: -e expression #1, char 4: unterminated `s' command

The error can be reproduced in a terminal:

[root@o2tests02 alice]# /root/alice/sw/slc7_x86-64/GEANT4/v10.5.1-3/bin/geant4-config --datasets | grep G4ENSDFSTATEDATA | sed 's/[^]*[^]*' '//'
sed: -e expression #1, char 10: unterminated `s' command

while the original expression works fine:

[root@o2tests02 alice]# /root/alice/sw/slc7_x86-64/GEANT4/v10.5.1-3/bin/geant4-config --datasets | grep G4ABLADATA | sed 's/[^ ]* [^ ]* //'
/root/alice/sw/slc7_x86-64/GEANT4/v10.5.1-3/share/Geant4-10.5.1/data/G4ABLA3.1

Is there a way to tell aliBuild not to add the '' ?
Thank you.

@ktf
Copy link
Member

ktf commented Sep 22, 2020

I think the correct way of escaping strings in YAML is:

G4ABLADATA: | ${G4INSTALL}/bin/geant4-config --datasets | grep G4ABLADATA | sed 's/[^ ]* [^ ]* //'

@ihrivnac
Copy link
Contributor Author

@ktf, thank you, but this gives me the following errors:

ERROR: Unable to parse alidist/geant4.sh
ERROR: while scanning a block scalar
ERROR:   in "<string>", line 17, column 15:
ERROR:       G4ABLADATA: | ${G4INSTALL}/bin/geant4-config ... 
ERROR:                   ^
ERROR: expected a comment or a line break, but found '$'
ERROR:   in "<string>", line 17, column 17:
ERROR:       G4ABLADATA: | ${G4INSTALL}/bin/geant4-config - ... 
ERROR:                     ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants