Particle type added for special reconstruction for triton and He3 #1224

mcolocci · 2020-09-17T14:06:32Z

No description provided.

alibuild · 2020-09-17T14:06:49Z

da952c6: approval required: 1 of @qgp (Jochen Klein), @shahor02 (Ruben Shahoyan), @sawenzel (Sandro Christian Wenzel), @pzhristov (Peter Hristov), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @ktf (Giulio Eulisse)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

chiarazampolli · 2020-09-17T20:12:53Z

STEER/ESD/AliESDpid.cxx

@@ -36,6 +36,7 @@
 #include "AliESDtrack.h"
 #include "AliMCEvent.h"
 #include "AliTOFPIDParams.h"
+#include "AliPID.h"


Is this include needed? It was not there before, and AliPID was used.

If the include was coming from other dependencies, its explicit inclusion will not do any harm, so, it is ok

Yes, sure, I would have avoided it if not needed, but I totally agree. I was curious to know why @mcolocci added it.

Ciao @chiarazampolli. About the AliPID dependence could be indeed avoided. I added at the beginning because we were seeing an error during the rebuild and at the first glance we thought they were related to it. Then, when I managed to rebuild fixing the error who was somewhere else…, I simply forgot to remove it. Thanks for checking!

chiarazampolli · 2020-09-17T20:14:30Z

Apart from a doubt on an include (which is in case harmless), to me it looks fine. @shahor02 , since you followed the development by @mpuccio some time ago, is it fine for you to merge?

shahor02 · 2020-09-17T20:21:25Z

+1

alibuild · 2020-09-17T20:21:45Z

da952c6: approved: will be automatically merged on successful tests

chiarazampolli · 2020-09-17T20:23:08Z

Yes, I also wrote that it is anyway harmless (but I asked Manuel, for completeness). What I wanted you to check was the rest :-)
Thanks for taking a look!

Chiara

shahor02 · 2020-09-17T20:32:59Z

@chiarazampolli I've looked the code also, looks fine. The class version does not need to be incremented if only static data member is added, but it also will not harm.

alibuild · 2020-09-17T20:39:22Z

Error while checking build/AliRoot/release for da952c6 at 2020-09-17 20:39:

sw/BUILD/AliRoot-guntest-latest/log

CINT/ROOT C/C++ Interpreter version 5.18.00, July 2, 2010
Type ? for help. Commands must be C++ statements.
Enclose multiple statements between { }.

Processing rec.C...
W-AliRawReader::Create: No raw-reader created
I-AliReconstruction::InitRawReader: Reconstruction will run over digits
I-AliCDBManager::Init: AliEn classes enabled in Root. AliCDBGrid factory registered.
E-AliRunLoader::Open: Can not find run-Loader in file galice.root.
E-AliReconstruction::SetRunNumberFromData: No run loader found in file galice.root
W-AliQAManager::QAManager: You must specify kSIMMODE or kRECMODE or kQAMODE
E-AliReconstruction::Abort: SetRunNumberFromData failed! Aborting...
I-AliReconstruction::AbortProcess: SetRunNumberFromData failed! Aborting...
Real time 0:00:00, CP time 0.120
W-AliQAManager::QAManager: You must specify kSIMMODE or kRECMODE or kQAMODE
AliReconstruction
   InitCDB  R:0.0282s C:0.0100s (1 slices)
   InitRawReader  R:0.0107s C:0.0000s (1 slices)
   InitRun  R:0.1535s C:0.1200s (1 slices)
   Run  R:0.1535s C:0.1200s (1 slices)
Warning in <TEnvRec::ChangeValue>: duplicate entry <Unix.*.Root.DynamicPath=.:$(ROOT_DYN_PATH):> for level 0; ignored
  *******************************************
  *                                         *
  *        W E L C O M E  to  R O O T       *
  *                                         *
  *   Version   5.34/30     23 April 2015   *
  *                                         *
  *  You are welcome to visit our Web site  *
  *          http://root.cern.ch            *
  *                                         *
  *******************************************

ROOT 5.34/30 (heads/v5-34-00-patches@v5-34-28-57-gec27989, Sep 01 2020, 16:41:00 on linuxx8664gcc)

CINT/ROOT C/C++ Interpreter version 5.18.00, July 2, 2010
Type ? for help. Commands must be C++ statements.
Enclose multiple statements between { }.

Processing /mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/AliRoot/build_AliRoot_release-1/STEER/macros/CheckESD.C...
E-AliRunLoader::Open: Can not find run-Loader in file galice.root.
E-CheckESD: getting run loader from file galice.root failed
(Bool_t)0
mv: cannot stat '*.rndm': No such file or directory
mv: cannot stat 'GRP': No such file or directory
++ WITHESDCHECK=
++ ./finalcheck.sh
check File not finished
Pythia Warning

Full log here.

chiarazampolli · 2020-09-17T20:46:31Z

Thanks Ruben!

Error expected and unrelated.

Chiara

alibuild · 2020-09-17T21:22:18Z

Error while checking build/AliRoot/macos for da952c6 at 2020-09-20 08:51:

sw/BUILD/AliRoot-guntest-latest/log
W-AliRawReader::Create: No raw-reader created
I-AliReconstruction::InitRawReader: Reconstruction will run over digits
I-AliCDBManager::Init: AliEn classes enabled in Root. AliCDBGrid factory registered.
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libTOFbase, output: $ROOT_DYN_PATH/libTOFbase
E-AliRunLoader::Open: Can not find run-Loader in file galice.root.
E-AliReconstruction::SetRunNumberFromData: No run loader found in file galice.root
W-AliQAManager::QAManager: You must specify kSIMMODE or kRECMODE or kQAMODE
E-AliReconstruction::Abort: SetRunNumberFromData failed! Aborting...
I-AliReconstruction::AbortProcess: SetRunNumberFromData failed! Aborting...
Real time 0:00:00, CP time 0.110
W-AliQAManager::QAManager: You must specify kSIMMODE or kRECMODE or kQAMODE
AliReconstruction
   InitCDB  R:0.0251s C:0.0100s (1 slices)
   InitRawReader  R:0.0131s C:0.0000s (1 slices)
   InitRun  R:0.1797s C:0.1100s (1 slices)
   Run  R:0.1797s C:0.1100s (1 slices)
Error in <TSystem::ExpandFileName>: input: $ROOT_DYN_PATH/libRIO, output: $ROOT_DYN_PATH/libRIO
Error in <TSystem::ExpandFileName>: input: $ROOT_DYN_PATH/libCling, output: $ROOT_DYN_PATH/libCling
Error in <TSystem::ExpandFileName>: input: $ROOT_DYN_PATH/libSTEER, output: $ROOT_DYN_PATH/libSTEER
   ------------------------------------------------------------------
  | Welcome to ROOT 6.20/02                        https://root.cern |
  | (c) 1995-2020, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for macosx64 on Sep 07 2020, 19:40:00                      |
  | From tags/v6-20-02-alice7@v6-07-06-16911-gdc5d774a41             |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'       |
   ------------------------------------------------------------------


Processing /System/Volumes/Data/build/ci_checks/aliroot_checker_macos_next-root6_ci_0/sw/osx_x86-64/AliRoot/1224-1/STEER/macros/CheckESD.C...
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libSTEER, output: $ROOT_DYN_PATH/libSTEER
 <message repeated 1 time>
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libESD, output: $ROOT_DYN_PATH/libESD
 <message repeated 4 times>
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libSTEER, output: $ROOT_DYN_PATH/libSTEER
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libSTEERBase, output: $ROOT_DYN_PATH/libSTEERBase
 <message repeated 5 times>
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libCDB, output: $ROOT_DYN_PATH/libCDB
 <message repeated 1 time>
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libTPCbase, output: $ROOT_DYN_PATH/libTPCbase
E-TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libTOFbase, output: $ROOT_DYN_PATH/libTOFbase
E-AliRunLoader::Open: Can not find run-Loader in file galice.root.
E-CheckESD: getting run loader from file galice.root failed
(bool) false
mv: rename *.rndm to g4/*.rndm: No such file or directory
mv: rename GRP to g4/GRP: No such file or directory
++ WITHESDCHECK=
++ ./finalcheck.sh
check File not finished
Pythia Warning

Full log here.

chiarazampolli · 2020-09-20T08:23:31Z

Hello @ktf ,

Will this PR go through the tests automatically after the change by @ihrivnac in alidist (alisw/alidist#2488)?

Cheers,

Chiara

Particle type added for special reconstruction for triton and He3

da952c6

chiarazampolli reviewed Sep 17, 2020

View reviewed changes

shahor02 approved these changes Sep 17, 2020

View reviewed changes

alibuild merged commit 9110b57 into alisw:master Sep 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Particle type added for special reconstruction for triton and He3 #1224

Particle type added for special reconstruction for triton and He3 #1224

mcolocci commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli Sep 17, 2020

shahor02 Sep 17, 2020

chiarazampolli Sep 17, 2020

mcolocci Sep 18, 2020

chiarazampolli commented Sep 17, 2020

shahor02 commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli commented Sep 17, 2020

shahor02 commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli commented Sep 17, 2020

alibuild commented Sep 17, 2020 •

edited

Loading

chiarazampolli commented Sep 20, 2020

Particle type added for special reconstruction for triton and He3 #1224

Particle type added for special reconstruction for triton and He3 #1224

Conversation

mcolocci commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli Sep 17, 2020

Choose a reason for hiding this comment

shahor02 Sep 17, 2020

Choose a reason for hiding this comment

chiarazampolli Sep 17, 2020

Choose a reason for hiding this comment

mcolocci Sep 18, 2020

Choose a reason for hiding this comment

chiarazampolli commented Sep 17, 2020

shahor02 commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli commented Sep 17, 2020

shahor02 commented Sep 17, 2020

alibuild commented Sep 17, 2020

chiarazampolli commented Sep 17, 2020

alibuild commented Sep 17, 2020 • edited Loading

chiarazampolli commented Sep 20, 2020

alibuild commented Sep 17, 2020 •

edited

Loading