Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new priority for workspace denied #1974

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Add new priority for workspace denied #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41b9be2
Add new priority for workspace denied
JimMadge Jun 28, 2024
cc8febb
Update data_safe_haven/types/enums.py
JimMadge Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_safe_haven/infrastructure/programs/sre/firewall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def __init__(
type=network.AzureFirewallRCActionType.DENY
),
name="workspaces-deny",
priority=FirewallPriorities.SRE_WORKSPACES,
priority=FirewallPriorities.SRE_WORKSPACES_DENY,
rules=[
network.AzureFirewallApplicationRuleArgs(
description="Deny external Ubuntu Snap Store upload and login access",
Expand Down
3 changes: 2 additions & 1 deletion data_safe_haven/types/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ class FirewallPriorities(int, Enum):
SRE_GUACAMOLE_CONTAINERS = 3100
SRE_IDENTITY_CONTAINERS = 3200
SRE_USER_SERVICES_SOFTWARE_REPOSITORIES = 3300
SRE_WORKSPACES = 3400
SRE_WORKSPACES_DENY = 3400
SRE_WORKSPACES = 3450


@verify(UNIQUE)
Expand Down
Loading