Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new priority for workspace denied #1974

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Add new priority for workspace denied #1974

merged 2 commits into from
Jun 29, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Jun 28, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Removes duplicate priority for firewall rule groups.

🌂 Related issues

🔬 Tests

Deployed SRE up to this point which now passes.

@JimMadge JimMadge requested a review from a team as a code owner June 28, 2024 13:49
@JimMadge JimMadge added the bug Problem when deploying a Data Safe Haven. label Jun 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/types
  enums.py
Project Total  

This report was generated by python-coverage-comment-action

jemrobinson
jemrobinson approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JimMadge @jemrobinson
Update data_safe_haven/types/enums.py
cc8febb 
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
@JimMadge JimMadge merged commit 87fe39b into develop Jun 29, 2024
9 of 10 checks passed
@JimMadge JimMadge deleted the fix_firewall_priority branch June 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemrobinson jemrobinson jemrobinson approved these changes

Assignees
No one assigned
Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimMadge @jemrobinson