Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for help function #1855

Merged

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

🌂 Related issues

Addresses point from #1853 review

🔬 Tests

Tested locally

@jemrobinson jemrobinson requested a review from a team as a code owner May 3, 2024 08:09
@jemrobinson jemrobinson requested a review from a team May 3, 2024 08:09
data_safe_haven/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I don't like how cli.py is structured. It isn't very idiomatic typer.

I think it would be much clearer and easier to use if it followed the normal model of a typer.Typer object and typer.Typer.command decorators.

@jemrobinson
Copy link
Member Author

In general, I don't like how cli.py is structured. It isn't very idiomatic typer.

I think it would be much clearer and easier to use if it followed the normal model of a typer.Typer object and typer.Typer.command decorators.

Are you happy to make that change on this PR?

@JimMadge JimMadge merged commit 9f8e124 into alan-turing-institute:develop May 7, 2024
10 checks passed
@jemrobinson jemrobinson deleted the 1853-add-dsh-help-test branch May 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants