Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular dependency in Context #1853

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented May 2, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Add ContextBase class to break circular dependency

🌂 Related issues

Closes #1852

🔬 Tests

Tested locally

@jemrobinson jemrobinson requested a review from a team as a code owner May 2, 2024 15:23
@jemrobinson jemrobinson requested a review from a team May 2, 2024 15:23
@jemrobinson jemrobinson force-pushed the 1852-fix-circular-import branch from e399afb to 93069fe Compare May 2, 2024 15:24
@jemrobinson jemrobinson force-pushed the 1852-fix-circular-import branch from 93069fe to 602a2fc Compare May 2, 2024 15:24
@jemrobinson jemrobinson merged commit 387ece4 into alan-turing-institute:develop May 2, 2024
10 checks passed
@JimMadge
Copy link
Member

JimMadge commented May 3, 2024

@jemrobinson Sorry, should have asked when reviewing, could you add a test which uses the top level Typer to show that this PR fixes the issue? (Could, for example, just run dsh --help)

@jemrobinson jemrobinson mentioned this pull request May 3, 2024
4 tasks
@jemrobinson jemrobinson deleted the 1852-fix-circular-import branch May 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI interface broken due to circular import
2 participants