Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.2): feat!: make delete directive non-strict by default #3502

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

akuitybot
Copy link

Automated backport to release-1.2, triggered by a label in #3498.

Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit ff51596
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67b04b3a9d3c4d000877b80f
😎 Deploy Preview https://deploy-preview-3502.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.45%. Comparing base (2af22e4) to head (ff51596).
Report is 1 commits behind head on release-1.2.

Files with missing lines Patch % Lines
internal/directives/file_deleter.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #3502      +/-   ##
===============================================
+ Coverage        52.44%   52.45%   +0.01%     
===============================================
  Files              291      291              
  Lines            26680    26687       +7     
===============================================
+ Hits             13992    13999       +7     
  Misses           11923    11923              
  Partials           765      765              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit 7b9b9e5)
@hiddeco hiddeco force-pushed the backport-3498-to-release-1.2 branch from 3bfe658 to ff51596 Compare February 15, 2025 08:07
@hiddeco hiddeco enabled auto-merge (squash) February 16, 2025 10:00
@hiddeco hiddeco merged commit 2a13cd4 into release-1.2 Feb 16, 2025
17 checks passed
@hiddeco hiddeco deleted the backport-3498-to-release-1.2 branch February 16, 2025 10:01
@krancour krancour added this to the v1.2.3 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants