feat!: make delete directive non-strict by default
#3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
==========================================
+ Coverage 52.25% 52.26% +0.01%
==========================================
Files 290 290
Lines 26307 26314 +7
==========================================
+ Hits 13747 13754 +7
Misses 11810 11810
Partials 750 750 ☔ View full report in Codecov by Sentry. |
800a0cb to
929d292
Compare
This makes a `delete` step succeed when a file or directory that is attempted to be removed already does not exist, instead of failing. In case this behavior is undesired, and the promotion has to fail when the path does not exist, the `strict` configuration option can be set to `true`. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
929d292 to
5018e44
Compare
krancour
approved these changes
Feb 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2025
Signed-off-by: Hidde Beydals <hidde@hhh.computer> (cherry picked from commit 7b9b9e5)
|
Successfully created backport PR for |
hiddeco
added a commit
that referenced
this pull request
Feb 15, 2025
Signed-off-by: Hidde Beydals <hidde@hhh.computer> (cherry picked from commit 7b9b9e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3497
This makes a
deletestep succeed when a file or directory that isattempted to be removed already does not exist, instead of failing.
In case this behavior is undesired, and the promotion has to fail
when the path does not exist, the
strictconfiguration option canbe set to
true.