Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump back to FSharp.Core 6.0.5 #6688

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Bump back to FSharp.Core 6.0.5 #6688

merged 6 commits into from
Apr 26, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Apr 26, 2023 •
edited
Loading

Fixes #6687

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

eaba
eaba commented Apr 26, 2023
View reviewed changes
Copy link
Contributor Author

@eaba eaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added FSharpVersion to common.props

src/common.props Outdated
@@ -23,6 +23,7 @@
<ProtobufVersion>3.22.1</ProtobufVersion>
<BenchmarkDotNetVersion>0.13.2</BenchmarkDotNetVersion>
<NetTestVersion>net7.0</NetTestVersion>
<FsharpVersion>6.0.6</FsharpVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add FSharpVersion

@eaba eaba changed the title Bump back to FSharp.Core 6.0.6 Bump back to FSharp.Core 6.0.5 Apr 26, 2023
Aaronontheweb
Aaronontheweb approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eaba eaba marked this pull request as ready for review April 26, 2023 16:50
@Aaronontheweb Aaronontheweb merged commit 4b8924d into akkadotnet:dev Apr 26, 2023
@eaba eaba deleted the fsharp branch April 27, 2023 10:42
@Arkatufus Arkatufus mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Akka.FSharp: need to pin FSharp.Core package version to 6.0
2 participants
@eaba @Aaronontheweb