Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.FSharp: need to pin FSharp.Core package version to 6.0 #6687

Closed
Aaronontheweb opened this issue Apr 26, 2023 · 5 comments · Fixed by #6688
Closed

Akka.FSharp: need to pin FSharp.Core package version to 6.0 #6687

Aaronontheweb opened this issue Apr 26, 2023 · 5 comments · Fixed by #6688

Comments

@Aaronontheweb
Copy link
Member

Version Information
Version of Akka.NET? v1.4.47 and later
Which Akka.NET Modules? Akka.FSharp, Akka.Persistence.FSharp

Describe the bug

A F# Akka.NET user reported in Discord that Akka.NET triggers a NuGet package downgrade warning when installing into a .NET 6 solution in F#:

  Akka1.5.3Test.fsproj: [NU1605] Detected package downgrade: FSharp.Core from 7.0.0 to 6.0.5. Reference the package directly from the project to select a different version. 
 Akka1.5.3Test -> Akka.FSharp 1.5.4 -> FSharp.Core (>= 7.0.0) 
 Akka1.5.3Test -> FSharp.Core (>= 6.0.5)

To Reproduce

Full repo from @hkirk here https://github.com/hkirk/Akka1.5.3Test

Expected behavior

Akka.FSharp should install normally into a .NET 6 application with no NuGet package downgrade warnings.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

.NET 6 and below - anything below .NET 7.

Additional context

Obviously this doesn't happen - the issue occurred in Akka.NET v1.4.47 when we removed explicit references to Akka.FSharp here #6641 and bumped to 7.x here #6402.

Both of these PRs should be reverted.

@Aaronontheweb
Copy link
Member Author

Both of these PRs should be reverted.

And FSharp.Core should be set to 6.x

@Aaronontheweb
Copy link
Member Author

We should also, and this can be done in a separate PR, tell Dependabot not to upgrade FSharp.Core.

@hkirk
Copy link

hkirk commented Jun 13, 2023

Hej @Aaronontheweb I still get this error on version 1.5.4-1.5.7.

I've updated the repository with newest version of Akka and Akka.FSharp

@hkirk
Copy link

hkirk commented Jun 13, 2023

I have a potential fix (work around) here: https://github.com/hkirk/Akka1.5.3Test/tree/work_around
But not sure this is the correct way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants