Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-dynamo] change dynamo primary key to use key schema #42398

Merged
merged 6 commits into from
Jul 22, 2024
Merged

[source-dynamo] change dynamo primary key to use key schema #42398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
864fb0f
change dynamo primary key to use key schema
AronsonDan Jul 22, 2024
07e78d3
change dynamo primary key to use key schema
AronsonDan Jul 22, 2024
3f558f0
add dep
AronsonDan Jul 22, 2024
781b985
add acceptance tests to metadata
AronsonDan Jul 22, 2024
12d00ac
bump version
AronsonDan Jul 22, 2024
031b840
Merge branch 'master' into danaronson/source-dynamodb-fix-primary-key
AronsonDan Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-dynamodb/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 50401137-8871-4c5a-abb7-1f5fda35545a
dockerImageTag: 0.3.2
dockerImageTag: 0.3.3
dockerRepository: airbyte/source-dynamodb
documentationUrl: https://docs.airbyte.com/integrations/sources/dynamodb
githubIssueLabel: source-dynamodb
Expand All @@ -23,6 +23,7 @@ data:
- language:java
connectorTestSuitesOptions:
- suite: unitTests
- suite: acceptanceTests
- suite: integrationTests
testSecrets:
- name: SECRET_SOURCE-DYNAMODB__CREDS
Expand Down
6 changes: 3 additions & 3 deletions ...ce-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
import java.util.Set;
import java.util.stream.Collectors;
import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
import software.amazon.awssdk.services.dynamodb.model.AttributeDefinition;
import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
import software.amazon.awssdk.services.dynamodb.model.DescribeTableRequest;
import software.amazon.awssdk.services.dynamodb.model.KeySchemaElement;
import software.amazon.awssdk.services.dynamodb.model.ListTablesRequest;
import software.amazon.awssdk.services.dynamodb.model.ListTablesResponse;
import software.amazon.awssdk.services.dynamodb.model.ScanRequest;
Expand Down Expand Up @@ -80,8 +80,8 @@ public List<String> listTables() {

public List<String> primaryKey(String tableName) {
DescribeTableRequest describeTableRequest = DescribeTableRequest.builder().tableName(tableName).build();
return dynamoDbClient.describeTable(describeTableRequest).table().attributeDefinitions().stream()
.map(AttributeDefinition::attributeName)
return dynamoDbClient.describeTable(describeTableRequest).table().keySchema().stream()
.map(KeySchemaElement::attributeName)
.toList();
}

Expand Down
13 changes: 7 additions & 6 deletions docs/integrations/sources/dynamodb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,16 @@ the underlying role executing the container workload in AWS.

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :-------------------------------------------------------- | :------------------------------------------------------------------- |
| 0.3.2 | 2024-05-01 | [27045](https://github.com/airbytehq/airbyte/pull/27045) | Fix missing scan permissions |
| 0.3.1 | 2024-05-01 | [31935](https://github.com/airbytehq/airbyte/pull/31935) | Fix list more than 100 tables |
| 0.3.0 | 2024-04-24 | [37530](https://github.com/airbytehq/airbyte/pull/37530) | Allow role based access |
| 0.2.3 | 2024-02-13 | [35232](https://github.com/airbytehq/airbyte/pull/35232) | Adopt CDK 0.20.4 |
| 0.2.2 | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
| 0.3.3 | 2024-07-22 | [*PR_NUMBER_PLACEHOLDER*](https://github.com/airbytehq/airbyte/pull/*PR_NUMBER_PLACEHOLDER*) | fix primary key fetching |
| 0.3.2 | 2024-05-01 | [27045](https://github.com/airbytehq/airbyte/pull/27045) | Fix missing scan permissions |
| 0.3.1 | 2024-05-01 | [31935](https://github.com/airbytehq/airbyte/pull/31935) | Fix list more than 100 tables |
| 0.3.0 | 2024-04-24 | [37530](https://github.com/airbytehq/airbyte/pull/37530) | Allow role based access |
| 0.2.3 | 2024-02-13 | [35232](https://github.com/airbytehq/airbyte/pull/35232) | Adopt CDK 0.20.4 |
| 0.2.2 | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
| 0.2.1 | 2024-01-03 | [#33924](https://github.com/airbytehq/airbyte/pull/33924) | Add new ap-southeast-3 AWS region |
| 0.2.0 | 18-12-2023 | https://github.com/airbytehq/airbyte/pull/33485 | Remove LEGACY state |
| 0.1.2 | 01-19-2023 | https://github.com/airbytehq/airbyte/pull/20172 | Fix reserved words in projection expression & make them configurable |
| 0.1.1 | 02-09-2023 | https://github.com/airbytehq/airbyte/pull/22682 | Fix build |
| 0.1.0 | 11-14-2022 | https://github.com/airbytehq/airbyte/pull/18750 | Initial version |

</details>
</details>
Loading