[source-dynamo] change dynamo primary key to use key schema #42398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
1 task
|
Hello your feedback matters a lot to us. Can you spare just 2 minutes to complete a survey? We’re dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve! |
xiaohansong
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changing the primary key method to use
keySchemain order to avoid #30250 in several destinationsHow
Use the keySchema attribute instead of
attributeDefinitionsReview guide
None
User Impact
Users will be able to upgrade their destinations while using their dynamo db sources
Can this PR be safely reverted and rolled back?