Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'dev' sentry environment for airbyte-ci pipx installs in PRs #33920

Merged
merged 10 commits into from
Jan 4, 2024
Merged

Use 'dev' sentry environment for airbyte-ci pipx installs in PRs #33920

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cbeb29e
report sentry environments
erohmensing Jan 3, 2024
29e99b8
update package version
erohmensing Jan 3, 2024
835296f
step-level env doesn't work
erohmensing Jan 3, 2024
04fe363
neither do conditionals in env
erohmensing Jan 3, 2024
61cf699
test: separate it as a command
erohmensing Jan 3, 2024
d17ba64
combine them
erohmensing Jan 3, 2024
2ff5707
format
erohmensing Jan 3, 2024
f4cc6e2
test: raise an exception to check sentry output
erohmensing Jan 3, 2024
1bb9b9c
new exception which shouldn't come to slack but should come to sentry
erohmensing Jan 3, 2024
7841ec6
remove test exceptions
erohmensing Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actions/run-dagger-pipeline/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ runs:
with:
python-version: "3.10"
token: ${{ inputs.github_token }}
env:
SENTRY_ENVIRONMENT: "production"

- name: Install ci-connector-ops package
if: github.ref != 'refs/heads/master' && steps.changes.outputs.pipelines_any_changed == 'true'
Expand All @@ -135,6 +137,8 @@ runs:
pip install pipx
pipx ensurepath
pipx install airbyte-ci/connectors/pipelines/
env:
SENTRY_ENVIRONMENT: "dev"

- name: Run airbyte-ci
shell: bash
Expand Down
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ E.G.: running `pytest` on a specific test folder:

| Version | PR | Description |
| ------- | ---------------------------------------------------------- | --------------------------------------------------------------------------------------------------------- |
| 2.13.1 | [#33920](https://github.com/airbytehq/airbyte/pull/33920) | Report different sentry environments
| 2.13.0 | [#33784](https://github.com/airbytehq/airbyte/pull/33784) | Make `airbyte-ci test` able to run any poetry command |
| 2.12.0 | [#33313](https://github.com/airbytehq/airbyte/pull/33313) | Add upgrade CDK command |
| 2.11.0 | [#32188](https://github.com/airbytehq/airbyte/pull/32188) | Add -x option to connector test to allow for skipping steps |
Expand Down
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/pipelines/helpers/sentry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def initialize():
if "SENTRY_DSN" in os.environ:
sentry_sdk.init(
dsn=os.environ.get("SENTRY_DSN"),
environment = os.environ.get("SENTRY_ENVIRONMENT") or "production",
before_send=before_send,
release=f"pipelines@{importlib.metadata.version('pipelines')}",
)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "2.13.0"
version = "2.13.1"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <contact@airbyte.io>"]

Expand Down
Loading