-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'dev' sentry environment for airbyte-ci pipx installs in PRs #33920
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -101,6 +101,17 @@ runs: | |||
pipelines: | |||
- 'airbyte-ci/connectors/pipelines/**' | |||
|
|||
- name: Determine how Airbyte CI should be installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this addition 😍
Use different sentry environments based on how we install Airbyte CI in PRs so that we can configure our alerting and sort our open issues on sentry.
After changing our slack alerts (still not sure why we have 2 different ones) explicitly to alert for the
production
environment (which is what all of our issues are being sent to currently), a new dev alert was not posted to slack.Closes #33892