Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAT: validate stream schemas to be valid json schemas #32787

Merged
merged 13 commits into from
Dec 5, 2023
Merged

CAT: validate stream schemas to be valid json schemas #32787

merged 13 commits into from
Dec 5, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Nov 24, 2023 •
edited by lazebnyi
Loading

What

Fixed #29422

How

  • Run json schema validation against every stream schema

roman-yermilov-gl and others added 10 commits November 20, 2023 14:52
@roman-yermilov-gl
Source Hubspot: fix expected records (#32645)
b611729
@roman-yermilov-gl
Source Github: fix expected records (#32644)
a9cc2b9
@ChristoGrab
✨ Source Mailchimp: Add Interests, InterestCategories, Tags streams (#…
e74bbde 
…32218)
@tolik0
🐛 Source Pinterest: Fix backoff waiting time (#32672)
918e64c
@tolik0
🚨🚨🐛 Source Pinterest: Update date-time fields with airbyte_type: time…
0f28144 
…stamp_without_timezone (#32595)
@edgao
remove bq+snowflake from legacy normalization docs (#32708)
39ac79c
@tolik0
🐛 Source Pinterest: Fix Advertiser stream names (#32734)
667be92
@tolik0
✨ Source Pinterest: Update docs and spec; add missing `placement_traf…
059ca2f 
…fic_type` field to AdGroups stream (#32747)
@tolik0
🐛 Source Facebook Marketing: Removed validation that blocked personal…
d81ae88 
… ad accounts during `check` (#32731)
@davydov-d
validate stream schemas to be valid json schemas
75f92c1
@davydov-d davydov-d requested a review from a team November 24, 2023 10:53
@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 5:33am

@davydov-d davydov-d changed the base branch from master to dev November 24, 2023 11:02
lazebnyi
lazebnyi approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 24, 2023 11:11
@davydov-d
Copy link
Collaborator Author

@evantahler can you please take a quick look?

bnchrch
bnchrch approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazebnyi THANK YOU SO MUCH FOR THIS! YES!

Did you have the time to run the CAT test against some connectors?

The only reason I ask is before we merge we should be reasonably sure we wont blow up the nightly reports.

Approving in advance though.

Thanks again

@katmarkham katmarkham removed the request for review from a team November 27, 2023 17:25
@lazebnyi lazebnyi self-assigned this Nov 29, 2023
@bnchrch
Copy link
Contributor

bnchrch commented Nov 30, 2023

@davydov-d @lazebnyi It looks like theres been a bad rebase? Could you take a look? Afterwards it seems like we should be good to merge :)

@lazebnyi lazebnyi changed the base branch from dev to master December 5, 2023 05:19
@lazebnyi lazebnyi merged commit 1ef5e80 into master Dec 5, 2023
@lazebnyi lazebnyi deleted the ddavydov/cat-discovery-ensure-valid-json branch December 5, 2023 05:48
@lazebnyi lazebnyi mentioned this pull request Dec 5, 2023
Closed
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
@davydov-d @roman-yermilov-gl
@ChristoGrab @tolik0 @edgao @lazebnyi @rishabh-cldcvr
CAT: validate stream schemas to be valid json schemas (airbytehq#32787)
af7a9bc 
Co-authored-by: Roman Yermilov [GL] <86300758+roman-yermilov-gl@users.noreply.github.com>
Co-authored-by: Christo Grabowski <108154848+ChristoGrab@users.noreply.github.com>
Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Co-authored-by: Serhii Lazebnyi <serhii.lazebnyi@globallogic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnchrch bnchrch bnchrch approved these changes

@tolik0 tolik0 tolik0 approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

@oustynova oustynova Awaiting requested review from oustynova

@darynaishchenko darynaishchenko Awaiting requested review from darynaishchenko

Assignees

@lazebnyi lazebnyi

Labels
connectors/source/facebook-marketing connectors/source/github connectors/source/hubspot connectors/source/mailchimp connectors/source/pinterest team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a CAT test to ensure the catalog has valid JSON nodes
8 participants
@davydov-d @bnchrch @tolik0 @lazebnyi @octavia-squidington-iii @roman-yermilov-gl @ChristoGrab @edgao