Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CAT test to ensure the catalog has valid JSON nodes #29422

Closed
bnchrch opened this issue Aug 15, 2023 · 1 comment · Fixed by #32787
Closed

Add a CAT test to ensure the catalog has valid JSON nodes #29422

bnchrch opened this issue Aug 15, 2023 · 1 comment · Fixed by #32787

Comments

@bnchrch
Copy link
Contributor

bnchrch commented Aug 15, 2023

First noticed: https://github.com/airbytehq/oncall/issues/2703
Sibling Issue: https://github.com/airbytehq/airbyte-internal-issues/issues/5136

Problem

We do not validate if the catalog emitted from a connector is valid json schema

As a result a catalog was persisted and used for months until the error was eventually caught by the Catalog Diff Method which throws an exception in this case
https://www.jsonschemavalidator.net/s/HU2gflxO

Quick Fix

We loosened the check of the catalog diff: airbytehq/airbyte-protocol#44

Long term fix

We add a CAT test that checks that all property nodes are valid json objects

@lazebnyi
Copy link
Collaborator

lazebnyi commented Dec 5, 2023

PR Merged - #32787

@lazebnyi lazebnyi closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants