Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎉 Free Connectors Program inline enrollment callout #21315
🪟 🎉 Free Connectors Program inline enrollment callout #21315
Changes from 27 commits
dbe90d3
4d7e002
5de24d1
9a5c61d
05fc5aa
c76278c
511fa47
abed550
ade40ff
5ab16e9
6197259
7f49e92
b8ceaf5
d353659
8973b8c
7424afb
b8e5f47
977ffc8
8056095
88aeb27
d88be33
0ceaaeb
0a54d6d
b310fc9
091cea4
f8ebe5e
e95eae4
04378b7
550173c
d240934
96c16f7
3ce0502
c5ae0be
0690c01
1fb68e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reflection, I think it makes most sense to put the
useExperiment
check inside theuseFreeConnectorProgramInfo
hook: it always has the same meaning vis a visshowEnrollmentUi
(if the flag is off, don't show the FCP UI), we'll always want to consider the two together while the flag is relevant, and pulling it into the hook gives us a single place to change if we end up making the experiment flag a permanent feature.No need to update this PR, though, I'm happy to do that in my PR that implements email verification status checking.