🪟 🎉 Free Connectors Program inline enrollment callout #21315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a249b32 to
5584655
Compare
This was referenced Jan 13, 2023
ambirdsall
reviewed
Jan 13, 2023
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
...packages/cloud/components/experiments/FreeConnectorProgram/hooks/useFreeConnectorProgram.tsx
Outdated
Show resolved
Hide resolved
...packages/cloud/components/experiments/FreeConnectorProgram/hooks/useFreeConnectorProgram.tsx
Outdated
Show resolved
Hide resolved
timroes
reviewed
Jan 16, 2023
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
teallarson
commented
Jan 17, 2023
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
6870736 to
e98af7c
Compare
ambirdsall
reviewed
Jan 17, 2023
There was a problem hiding this comment.
I've added the hook to query the backend for enrollment eligibility (with a hardcoded boolean for the email verification issue that was raised this morning) to #21414
...packages/cloud/components/experiments/FreeConnectorProgram/hooks/useFreeConnectorProgram.tsx
Outdated
Show resolved
Hide resolved
9b77479 to
091cea4
Compare
ambirdsall
approved these changes
Jan 18, 2023
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
| @@ -23,6 +27,11 @@ export const ConnectionPageTitle: React.FC = () => { | |||
|
|
|||
| const { connection } = useConnectionEditService(); | |||
|
|
|||
| const freeConnectorProgramEnabled = useExperiment("workspace.freeConnectorsProgram.visible", false); | |||
There was a problem hiding this comment.
On reflection, I think it makes most sense to put the useExperiment check inside the useFreeConnectorProgramInfo hook: it always has the same meaning vis a vis showEnrollmentUi (if the flag is off, don't show the FCP UI), we'll always want to consider the two together while the flag is relevant, and pulling it into the hook gives us a single place to change if we end up making the experiment flag a permanent feature.
No need to update this PR, though, I'm happy to do that in my PR that implements email verification status checking.
josephkmh
approved these changes
Jan 18, 2023
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Outdated
Show resolved
Hide resolved
...p/src/packages/cloud/components/experiments/FreeConnectorProgram/InlineEnrollmentCallout.tsx
Show resolved
Hide resolved
|
@josephkmh not sure why I can't reply or quote reply, but RE links: Yep, a unified component would be useful. We have an existing issue here: #18825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #21222
Shows callout to enroll if a user:
How
Recommended reading order
useFreeConnectorProgram.tsxInlineEnrollmentCallout.*