-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homogenise and debug RL solvers and implement action masking in RLlib #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neo-alex
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you!
fteicht
added a commit
that referenced
this pull request
Jan 26, 2024
This commit improves the support of unified planning in scikit-decide, notably enabling to solve UP domains with the RLlib solver. It relies on: - the recent handling of state-based applicable actions, which are produced by unified planning domains, in the RLlib solver (PR #308) ; - the automatic translation to/from unified planning states and actions from/to numpy arrays that can be handled by RLlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR both improves the RL experience in scikit-decide and corrects some bugs in the RL solvers:
_get_application_actions_from()
gym.Space
DictSpace
andTupleSpace
to use subspaces optionally deriving fromGymSpace
, and implements proper recursive unwrapping and wrapping of elements belonging to those subspacesSetSpace
space that derives fromGymSpace
and that provides efficient search in thecontains
methodMaze
,SimpleGridWorld
andMastermind
to be solvable by RLlib in addition to StableBaselinesreset
method did not unwrap the initial observation_sample_action
method did not unwrap the current observation