Improve unified planning support #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-poveda
reviewed
Jan 25, 2024
g-poveda
reviewed
Jan 25, 2024
| @@ -9,15 +9,14 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.version_info < (3, 10), reason="requires python3.10 or higher") | |||
| def test_up_bridge_domain(): | |||
| def test_up_bridge_domain_random(): | |||
| noexcept = True | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
it can be the opportunity to remove the try except here ?
g-poveda
reviewed
Jan 25, 2024
| @@ -420,7 +420,7 @@ def get_elements(self) -> Iterable[T]: | |||
| return self._elements | |||
|
|
|||
| def sample(self) -> T: | |||
| return self._elements[super().sample()] | |||
| return self._to_elements[super().sample()] | |||
There was a problem hiding this comment.
is it a bug you found during this PR implementation ?
There was a problem hiding this comment.
Correct, I found this bug when calling the sample method of SetSpace in the UP bridge unit tests.
There are 2 kinds of commits here:
|
g-poveda
requested changes
Jan 26, 2024
g-poveda
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the support of unified planning in scikit-decide, notably enabling to solve UP domains with the RLlib solver. It relies on: