Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9726/c3a9c3e backport][3.10] Make enable_cleanup_closed a NOOP for Python 3.12.7+ and 3.13.1+ #9734

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 9, 2024

(cherry picked from commit c3a9c3e)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 9, 2024
@bdraco bdraco changed the title Make enable_cleanup_closed a NOOP for Python 3.12.7+ and 3.13.1+ (#9726) [PR #9726/c3a9c3e backport][3.10] Make enable_cleanup_closed a NOOP for Python 3.12.7+ and 3.13.1+ Nov 9, 2024
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #9734 will not alter performance

Comparing patchback/backports/3.10/c3a9c3e67b6ad39e28095fd478e86053b34a7e45/pr-9726 (b054963) with 3.10 (edc0c07)

Summary

✅ 14 untouched benchmarks

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (edc0c07) to head (b054963).
Report is 2 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9734      +/-   ##
==========================================
+ Coverage   96.71%   97.86%   +1.15%     
==========================================
  Files         110      112       +2     
  Lines       35455    35548      +93     
  Branches     3439     4279     +840     
==========================================
+ Hits        34290    34790     +500     
+ Misses        901      565     -336     
+ Partials      264      193      -71     
Flag Coverage Δ
CI-GHA 97.76% <100.00%> (+1.04%) ⬆️
OS-Linux 97.45% <100.00%> (?)
OS-Windows 95.02% <100.00%> (?)
OS-macOS 97.14% <100.00%> (+0.43%) ⬆️
Py-3.10.11 97.01% <100.00%> (+0.29%) ⬆️
Py-3.10.15 96.95% <100.00%> (?)
Py-3.11.10 97.01% <100.00%> (?)
Py-3.11.9 97.09% <100.00%> (?)
Py-3.12.7 97.48% <100.00%> (?)
Py-3.13.0 97.47% <100.00%> (?)
Py-3.8.10 94.42% <100.00%> (?)
Py-3.8.18 96.75% <100.00%> (?)
Py-3.9.13 96.92% <100.00%> (?)
Py-3.9.20 96.87% <100.00%> (?)
Py-pypy7.3.16 96.47% <100.00%> (?)
VM-macos 97.14% <100.00%> (+0.43%) ⬆️
VM-ubuntu 97.45% <100.00%> (?)
VM-windows 95.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 9, 2024 14:02
@bdraco bdraco enabled auto-merge (squash) November 9, 2024 14:02
@bdraco bdraco merged commit a406b18 into 3.10 Nov 9, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/c3a9c3e67b6ad39e28095fd478e86053b34a7e45/pr-9726 branch November 9, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant