-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make enable_cleanup_closed
a NOOP for Python 3.12.7+ and 3.13.1+
#9726
Conversation
python/cpython#118960 has been fixed an asyncio no longer leaks SSL connections
CodSpeed Performance ReportMerging #9726 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9726 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 117 117
Lines 35787 35807 +20
Branches 4239 4250 +11
=======================================
+ Hits 35313 35333 +20
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c3a9c3e on top of patchback/backports/3.10/c3a9c3e67b6ad39e28095fd478e86053b34a7e45/pr-9726 Backporting merged PR #9726 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c3a9c3e on top of patchback/backports/3.11/c3a9c3e67b6ad39e28095fd478e86053b34a7e45/pr-9726 Backporting merged PR #9726 into master
🤖 @patchback |
…OP for Python 3.12.7+ and 3.13.1+ (#9734)
…OP for Python 3.12.7+ and 3.13.1+ (#9735)
We still need the argument for older Python releases, but newer releases will emit a DeprecationWarning. See: aio-libs/aiohttp#9726
We still need the argument for older Python releases, but newer releases will emit a DeprecationWarning. See: aio-libs/aiohttp#9726
What do these changes do?
python/cpython#118960 has been fixed, and asyncio no longer leaks SSL connections which means
enable_cleanup_closed
is unnecessary for fixed Python versionsAre there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
Related issue number
closes #9590