Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9713/500a021 backport][3.10] Small cleanups to creating a ClientRequest #9716

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 7, 2024

(cherry picked from commit 500a021)

@bdraco bdraco changed the title Small cleanups to creating a ClientRequest (#9713) [PR #9713/500a021 backport][3.10] Small cleanups to creating a ClientRequest Nov 7, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 7, 2024
@bdraco bdraco marked this pull request as ready for review November 7, 2024 22:37
@bdraco bdraco requested a review from asvetlov as a code owner November 7, 2024 22:37
@bdraco bdraco enabled auto-merge (squash) November 7, 2024 22:37
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #9716 will not alter performance

Comparing patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 (e9c04da) with 3.10 (b1bd55b)

Summary

✅ 14 untouched benchmarks

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (b1bd55b) to head (e9c04da).
Report is 49 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9716      +/-   ##
==========================================
- Coverage   97.87%   97.87%   -0.01%     
==========================================
  Files         112      112              
  Lines       35527    35525       -2     
  Branches     4269     4268       -1     
==========================================
- Hits        34772    34769       -3     
  Misses        564      564              
- Partials      191      192       +1     
Flag Coverage Δ
CI-GHA 97.76% <100.00%> (-0.01%) ⬇️
OS-Linux 97.45% <100.00%> (-0.01%) ⬇️
OS-Windows 95.02% <100.00%> (-0.01%) ⬇️
OS-macOS 97.15% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.01% <100.00%> (-0.01%) ⬇️
Py-3.10.15 96.95% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.02% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.10% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.48% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.47% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.41% <100.00%> (-0.01%) ⬇️
Py-3.8.18 96.74% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.92% <100.00%> (-0.01%) ⬇️
Py-3.9.20 96.87% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.47% <100.00%> (-0.01%) ⬇️
VM-macos 97.15% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.45% <100.00%> (-0.01%) ⬇️
VM-windows 95.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit edc0c07 into 3.10 Nov 7, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 branch November 7, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant