Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups to creating a ClientRequest #9713

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 7, 2024

  • Change URL checks to type instead of isinstance (faster) since sub-classing is forbidden
  • Change cast to assert since its only used for tests

- Change URL checks to type since sub-classing is forbidden
- Change cast to assert since its only used for tests
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 7, 2024
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #9713 will not alter performance

Comparing client_request_create (e6ce88f) with master (b40265e)

Summary

✅ 14 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review November 7, 2024 22:10
@bdraco bdraco requested a review from asvetlov as a code owner November 7, 2024 22:10
@bdraco bdraco enabled auto-merge (squash) November 7, 2024 22:11
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (b40265e) to head (e6ce88f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9713      +/-   ##
==========================================
- Coverage   98.67%   98.67%   -0.01%     
==========================================
  Files         117      117              
  Lines       35789    35787       -2     
  Branches     4240     4239       -1     
==========================================
- Hits        35315    35313       -2     
  Misses        319      319              
  Partials      155      155              
Flag Coverage Δ
CI-GHA 98.56% <100.00%> (-0.01%) ⬇️
OS-Linux 98.23% <100.00%> (-0.01%) ⬇️
OS-Windows 95.99% <100.00%> (-0.01%) ⬇️
OS-macOS 97.30% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.71% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.77% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.26% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.25% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.08% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.63% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.25% <100.00%> (-0.01%) ⬇️
VM-macos 97.30% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.23% <100.00%> (-0.01%) ⬇️
VM-windows 95.99% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 500a021 into master Nov 7, 2024
39 of 40 checks passed
@bdraco bdraco deleted the client_request_create branch November 7, 2024 22:25
Copy link
Contributor

patchback bot commented Nov 7, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 500a021 on top of patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713

Backporting merged PR #9713 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 upstream/3.10
  4. Now, cherry-pick PR Small cleanups to creating a ClientRequest #9713 contents into that branch:
    $ git cherry-pick -x 500a02194cc30a1c15b900269882bdc62115c7c8
    If it'll yell at you with something like fatal: Commit 500a02194cc30a1c15b900269882bdc62115c7c8 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 500a02194cc30a1c15b900269882bdc62115c7c8
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Small cleanups to creating a ClientRequest #9713 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 7, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 500a021 on top of patchback/backports/3.11/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713

Backporting merged PR #9713 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 upstream/3.11
  4. Now, cherry-pick PR Small cleanups to creating a ClientRequest #9713 contents into that branch:
    $ git cherry-pick -x 500a02194cc30a1c15b900269882bdc62115c7c8
    If it'll yell at you with something like fatal: Commit 500a02194cc30a1c15b900269882bdc62115c7c8 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 500a02194cc30a1c15b900269882bdc62115c7c8
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Small cleanups to creating a ClientRequest #9713 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Nov 7, 2024
bdraco added a commit that referenced this pull request Nov 7, 2024
bdraco added a commit that referenced this pull request Nov 7, 2024
bdraco added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant