-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanups to creating a ClientRequest #9713
Conversation
- Change URL checks to type since sub-classing is forbidden - Change cast to assert since its only used for tests
CodSpeed Performance ReportMerging #9713 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9713 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 117 117
Lines 35789 35787 -2
Branches 4240 4239 -1
==========================================
- Hits 35315 35313 -2
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 500a021 on top of patchback/backports/3.10/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 Backporting merged PR #9713 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 500a021 on top of patchback/backports/3.11/500a02194cc30a1c15b900269882bdc62115c7c8/pr-9713 Backporting merged PR #9713 into master
🤖 @patchback |
(cherry picked from commit 500a021)
(cherry picked from commit 500a021)
type
instead ofisinstance
(faster) since sub-classing is forbiddencast
toassert
since its only used for tests