Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8546/a561fa99 backport][3.10] Fix WebSocket server heartbeat timeout logic #8573

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 1, 2024

Co-authored-by: J. Nick Koston nick@koston.org
(cherry picked from commit 4140b0e)

Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 4140b0e)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 1, 2024
@bdraco bdraco changed the title Fix WebSocket server heartbeat timeout logic (#8546) [PR #8546/a561fa99 backport][3.10] Fix WebSocket server heartbeat timeout logic Aug 1, 2024
@bdraco bdraco marked this pull request as ready for review August 1, 2024 15:35
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (bf5a66f) to head (821f794).
Report is 200 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8573      +/-   ##
==========================================
+ Coverage   97.57%   97.60%   +0.02%     
==========================================
  Files         108      108              
  Lines       33634    33656      +22     
  Branches     4034     4037       +3     
==========================================
+ Hits        32819    32849      +30     
+ Misses        594      589       -5     
+ Partials      221      218       -3     
Flag Coverage Δ
CI-GHA 97.50% <100.00%> (+0.02%) ⬆️
OS-Linux 97.17% <100.00%> (+0.01%) ⬆️
OS-Windows 94.70% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.85% <100.00%> (+0.02%) ⬆️
Py-3.10.11 96.93% <100.00%> (+0.01%) ⬆️
Py-3.10.14 96.89% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.13% <100.00%> (+0.01%) ⬆️
Py-3.12.4 97.24% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.43% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.79% <100.00%> (+0.01%) ⬆️
Py-3.9.13 96.94% <100.00%> (+0.02%) ⬆️
Py-3.9.19 96.90% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 96.47% <100.00%> (+0.02%) ⬆️
VM-macos 96.85% <100.00%> (+0.02%) ⬆️
VM-ubuntu 97.17% <100.00%> (+0.01%) ⬆️
VM-windows 94.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 0e6bbbc into 3.10 Aug 1, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/4140b0eda3658a3f6bd5a9479553aae4a0c14bb8/pr-8546 branch August 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants