[3.10] WSS: Fix heartbeat timeout logic #8543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to unblock the `receive` operation by feeding the receiver an error in a `WSMessage` Change `TimeoutError` to `ServerTimeoutError` to accurately represent failure (this is backwards compatible since `ServerTimeoutError` has `TimeoutError` in the MRO) fixes aio-libs#8540
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8543 +/- ##
==========================================
+ Coverage 97.57% 97.58% +0.01%
==========================================
Files 108 108
Lines 33582 33606 +24
Branches 4029 4033 +4
==========================================
+ Hits 32767 32795 +28
+ Misses 594 591 -3
+ Partials 221 220 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d816fca to
32994c4
Compare
32994c4 to
56c0f1f
Compare
|
@bdraco @Dreamsorcerer Please provide feedback based on this PR and if satisfactory I'll adopt it to master as well. Please let me know if you think documentation changes are necessary. |
|
superseded by #8573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to unblock the
receiveoperation by feeding the receiver an error in aWSMessageChange
TimeoutErrortoServerTimeoutErrorto accurately represent failure (this is backwards compatible sinceServerTimeoutErrorhasTimeoutErrorin the MRO)fixes #8540
Checklist
CONTRIBUTORS.txtCHANGES/folder