Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#306] Remove atoi() in as_logging_level() #307

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[#306] Remove atoi() in as_logging_level() #307

merged 1 commit into from
Aug 15, 2022

Conversation

fluca1978
Copy link
Collaborator

Use the internal function as_int() that checks for overflows and not
parsable strings.

Close #306

@fluca1978
[agroal#306] Remove atoi() in as_logging_level()
1989692 
Use the internal function `as_int()` that checks for overflows and not
parsable strings.

Documentation updated.

Close agroal#306
@fluca1978 fluca1978 force-pushed the as_logging_mode_improvement branch from 9c02f0f to 1989692 Compare August 12, 2022 11:04
@jesperpedersen jesperpedersen merged commit 1989692 into agroal:master Aug 15, 2022
@jesperpedersen jesperpedersen added the enhancement Improvement to an existing feature label Aug 15, 2022
@jesperpedersen
Copy link
Collaborator

Merged.

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fluca1978 fluca1978

Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve function as_logging_level()()
2 participants
@fluca1978 @jesperpedersen