Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve function as_logging_level()() #306

Closed
fluca1978 opened this issue Aug 12, 2022 · 0 comments · Fixed by #307
Closed

Improve function as_logging_level()() #306

fluca1978 opened this issue Aug 12, 2022 · 0 comments · Fixed by #307

Comments

@fluca1978
Copy link
Collaborator

fluca1978 commented Aug 12, 2022 •
edited
Loading

In function as_logging_level() there is usage of atoi() which is not ideal. Since we already have as_int() that catches parsing errors and overflows, we should remove atoi() in favor of as_int().
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Aug 12, 2022
@fluca1978
[agroal#306] Remove atoi() in as_logging_level()
9c02f0f 
Use the internal function `as_int()` that checks for overflows and not
parsable strings.

Close agroal#306
@fluca1978 fluca1978 mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#306] Remove atoi() in as_logging_level() fluca1978/pgagroal
1 participant
@fluca1978