Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Has Been Refactored with New Infrastructure #41

Merged
merged 138 commits into from
May 14, 2023
Merged

Project Has Been Refactored with New Infrastructure #41

merged 138 commits into from
May 14, 2023

Conversation

agitrubard
Copy link
Collaborator

@agitrubard agitrubard commented Apr 22, 2023 •
edited
Loading

This pull request includes code changes to refactor the project with a new infrastructure. The changes were made to make the project run more efficiently and reliably.

Changes Made

  • Cleaned up the old code structure and replaced it with the new infrastructure.
  • Made the code compatible with the new infrastructure.
  • Removed unnecessary files.
  • Removed unnecessary code.
  • Rewrote some of the code.
  • Refactored the token infrastructure.
  • Refactored authentication/authorization flows.
  • Added controller/unit tests.
  • Refactored all user flows.

New Infrastructure

ays-be-layer drawio
ays-be-package drawio

agitrubard and others added 30 commits April 14, 2023 22:04
@agitrubard
The Project Infrastructure Has Been Standardized and Completely Renewed
ec6817c
@agitrubard
Application YAML Files Have Been Fixed
838e207
@agitrubard
Docker Compose File Has Been Added for Production
c21fc4d
@Rapter1990
Add comments for explanation of each service info and delete applicat…
00b1fa7 
…ion-test.yaml
@Rapter1990
Merge remote-tracking branch 'origin/refactor/new-infrastructure' int…
b859943 
…o refactor/new-infrastructure
@agitrubard
AYS_PARAMETER Table Has Been Created & Data Have Been Inserted to T…
a07194b 
…able
@agitrubard
AysUserDetailsServiceImpl Class Has Been Removed Because It's Unused
7737eb3
@agitrubard
@Getter Annotation Has Been Added to UsersResponse Class
b1a628b
@agitrubard
Annotations Have Been Fixed for Entity Classes
3ac492c
@agitrubard
AYS Parameter Service & Repository Has Been Created for Reading Param…
5c416bf 
…eters from Database
@agitrubard
Merge remote-tracking branch 'origin/refactor/new-infrastructure' int…
9f1ed99 
…o refactor/new-infrastructure
@agitrubard
AYS Token Configuration Has Been Updated with Reading from DB
1ae8bfe
@agitrubard
Read Private and Public Key Parameter Flow Has Been Fixed
0059049
@agitrubard
Documentations Have Been Added
d03c58d
@skayikci
add rds mysql driver.
122219d
@skayikci
Update AysHikariConfigMysqlProfile.java
b347f5d 
add logging, change driver for hikaripool
@skayikci
Update application-development.yml
a5bb52e 
change settings for the db.
@skayikci
latest updates
e449c31 
latest updates regarding the env settings for docker compose.
@agitrubard
Project Refactoring Tests Have Been Started
e4c750d
@agitrubard
Merge remote-tracking branch 'origin/refactor/new-infrastructure' int…
1055837 
…o refactor/new-infrastructure
@agitrubard
application-development.yml and application-production.yml Files …
4a4360f 
…Have Been Fixed
@agitrubard
Tests Have Been Added and Codes Have Been Refactored
1585d19
@agitrubard
Project Refactored
7efee40
@agitrubard
Merge remote-tracking branch 'origin/main' into refactor/new-infrastr…
6efb3c8 
…ucture

# Conflicts:
#	src/main/java/com/ays/backend/config/SecurityConfig.java
@agitrubard
Revert | Permission of Actuator (#40)
e2843ab
@agitrubard
AysUserDetails Class Has Been Removed Because It's Unused
c4eeeb2
@agitrubard
Production Files Have Been Configured
bedac49
@agitrubard
Production Files Have Been Configured
24a5711
@agitrubard
Docker Files Have Been Updated
8737a33
@agitrubard
README.md File Has Been Updated
7eba5c9
agitrubard added 20 commits May 11, 2023 21:04
@agitrubard
Extends AysNotActiveException in AysUserNotActiveException Class
ac0fa7f
@agitrubard
Codes Have Been Refactored
850bb64
@agitrubard
User Update Flow Has Been Refactored
da642ac
@agitrubard
OrganizationEntityBuilder Class Has Been Created
6750538
@agitrubard
UserEntityBuilder.withValidFields() Method Has Been Updated with Ge…
3b6a6df 
…nerated OrganizationEntity
@agitrubard
withRole() and withStatus() Methods Have Been Added to `UserUpdat…
c544f87 
…eRequestBuilder` Class
@agitrubard
User Controller Tests Have Been Refactored and Updated
c08e80c
@agitrubard
User Service Tests Have Been Refactored and Updated
7806ea6
@agitrubard
User Controller Tests Have Been Fixed
656efa9
@agitrubard
AysParameterBuilder Class Has Been Refactored
6ca8988
@agitrubard
Java DOC Has Been Added for AysTokenServiceImpl Class
f9f604d
@agitrubard
accessExpireMinute Parameter Has Been Renamed as `accessTokenExpire…
2063f4c 
…Minute` & `refreshExpireDay` Parameter Has Been Renamed as `refreshTokenExpireDay`
@agitrubard
accessExpireMinute Parameter Has Been Renamed as `accessTokenExpire…
95c6bcf 
…Minute` & `refreshExpireDay` Parameter Has Been Renamed as `refreshTokenExpireDay` in `AbstractRestControllerTest` Class
@agitrubard
IllegalArgumentException Has Been Changed as `AysUnexpectedArgument…
c9397dd 
…Exception`
@agitrubard
AysTokenService Class Has Been Covered End to End with Unit Tests
09ff743
@agitrubard
Unused Case Has Been Removed in AysTokenService.getAuthentication()…
19411d4 
… Method
@agitrubard
OrganizationStatus Class Has Been Used in OrganizationEntity Class
badb574
@agitrubard
AysRoleNotExistException Has Been Removed Because It's Unused
ef5c005
@agitrubard
Java DOC Fixes
bd882d5
@agitrubard
Missing Java DOCs Have Been Added
8d05316
skayikci
skayikci approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you very much.

This was linked to issues May 14, 2023
I want to register a volunteer to the platform as an institutions admin #14
Closed
as a user, I want to login via an user panel #34
Closed
@agitrubard agitrubard merged commit 69d54d5 into main May 14, 2023
@agitrubard agitrubard deleted the refactor/new-infrastructure branch May 14, 2023 11:16
@agitrubard agitrubard linked an issue May 23, 2023 that may be closed by this pull request
I want to login via an admin panel as an institutions admin #13
Closed
@agitrubard agitrubard modified the milestone: v1.0.0 May 23, 2023
@agitrubard agitrubard added this to the v1.0.0 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skayikci skayikci skayikci approved these changes

@halilturkoglucs halilturkoglucs Awaiting requested review from halilturkoglucs

@Rapter1990 Rapter1990 Awaiting requested review from Rapter1990

Assignees

@agitrubard agitrubard

Labels
feature New feature or request
Projects
No open projects
AYS | Back-End Board
Status: Done
Milestone
v1.0.0.MVP
3 participants
@agitrubard @skayikci @Rapter1990