Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission of Actuator #40

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Permission of Actuator #40

merged 2 commits into from
Apr 9, 2023

Conversation

Rapter1990
Copy link
Contributor

What I have done in the security config to give a permission to /actuator to access its features

@Rapter1990 Rapter1990 requested a review from agitrubard April 8, 2023 03:40
@Rapter1990 Rapter1990 self-assigned this Apr 8, 2023
@Rapter1990 Rapter1990 added the feature New feature or request label Apr 8, 2023
skayikci
skayikci requested changes Apr 9, 2023
View reviewed changes
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure to limit the access to the super admins only.

@skayikci
Copy link
Collaborator

skayikci commented Apr 9, 2023

please provide the necessary test cases to test the behaviours.

@Rapter1990
Copy link
Contributor Author

@skayikci
I'll revise the line as shown below

.antMatchers(HttpMethod.GET,"/actuator/**").hasRole("SUPER_ADMIN")

@Rapter1990
Copy link
Contributor Author

@skayikci
testActuatorEndpointsAccessWithUserRole method produces 200 Ok instead of 403 Forbidden.

@Rapter1990 Rapter1990 requested a review from skayikci April 9, 2023 04:31
@skayikci
Copy link
Collaborator

skayikci commented Apr 9, 2023

The problem occurs for the same reason as refresh token exchange endpoints. Please have a look when you are working on refactoring.

@Rapter1990 Rapter1990 merged commit 04fa934 into main Apr 9, 2023
@Rapter1990 Rapter1990 deleted the features/actuator branch April 9, 2023 22:15
agitrubard added a commit that referenced this pull request Apr 20, 2023
@agitrubard
Revert | Permission of Actuator (#40)
e2843ab
@agitrubard agitrubard added this to the v1.0.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skayikci skayikci skayikci approved these changes

@agitrubard agitrubard agitrubard approved these changes

Assignees

@Rapter1990 Rapter1990

Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0.MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@Rapter1990 @skayikci @agitrubard