Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review dontrun blocks in examples #598

Merged
merged 4 commits into from
Jun 7, 2023
Merged

review dontrun blocks in examples #598

merged 4 commits into from
Jun 7, 2023

Conversation

adokter
Copy link
Owner

@adokter adokter commented Jun 7, 2023

Addressing issue #528

Removed dontrun blocks as much as possible. Remaining examples in \dontrun blocks are there because:

  • execution time > 5s, which could trigger a note on CRAN
  • the example downloads remote data, and therefore requires an internet connection

Also made sure a devtools::check(run_dont_run=TRUE) completes successfully without triggering warnings/errors, fixing #562

Because some dontrun blocks remain, for CRAN release documentation we will still need to generate the webpage with a pkgdown::build_site(run_dont_run=TRUE) vall

@adokter adokter changed the title Review dontrun review dontrun blocks in examples Jun 7, 2023
@adokter adokter merged commit 9183086 into master Jun 7, 2023
@peterdesmet peterdesmet mentioned this pull request Jun 8, 2023
26 tasks
@adokter adokter mentioned this pull request Sep 5, 2023
27 tasks
@adokter adokter mentioned this pull request Oct 20, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants