258 Indicate if default transformation file is being used #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kptdobe
approved these changes
Sep 16, 2024
kptdobe
requested changes
Sep 16, 2024
Oh. Of course. Good idea. Done. |
- Add indicator for bulk-import as well.
kptdobe
approved these changes
Sep 17, 2024
|
Thanks @atopper! |
adobe-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
# [1.52.0](v1.51.39...v1.52.0) (2024-09-17) ### Features * **import:** indicate if default transformation file is being used ([#427](#427)) ([13500e6](13500e6))
|
🎉 This PR is included in version 1.52.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A non-existent transformation file is allows, as the default one will then be used, but if a non-existent one is used by accident, it causes confusion for the user, since they think their import script is broken.
If the default transformation file is being used, give the user a subtle note about it is happening.
Related Issue
#258
Motivation and Context
Small note to avoid confusion.
How Has This Been Tested?
Tested locally, doing imports with the existing files, non-existing files and plain old strangely spelled files.
Screenshots (if appropriate):
Types of changes
Checklist:
@kptdobe For your consideration...