Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid "Transformation file URL" should throw an error #258

Closed
synox opened this issue Sep 15, 2023 · 2 comments · Fixed by #427
Closed

invalid "Transformation file URL" should throw an error #258

synox opened this issue Sep 15, 2023 · 2 comments · Fixed by #427

Comments

@synox
Copy link

synox commented Sep 15, 2023

I don't like the behavior when having a typo in the url.

Expected Behaviour

It should show an error: "Tranformation file not found"

Actual Behaviour

An import it run with the default config, and overrides any existing word documents.

@kptdobe
Copy link
Contributor

kptdobe commented Sep 15, 2023

No import file is a valid use case ("default import") and you can easily see in the console log that the file cannot be found (red 404 error).
Maybe simply showing a message like "No transformation file found, using the default one" to inform the user could be a good compromise.

@atopper
Copy link
Collaborator

atopper commented Sep 13, 2024

I've heard this from different people myself, that a misspelling of the transformation file has lead them astray.
I suggest a little subtle note (not a toast as they might miss it). Something like this which might be shown if the file can't be loaded and checked when the input is changed or when the "Import" button is pressed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants