Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix live preview refresh issues (again) #3928

Merged
merged 2 commits into from
May 21, 2013
Merged

Conversation

jasonsanjose
Copy link
Member

Replaces original pull #3852
#3761 I found 2 issues here:

  • When hitting refresh rapidly, the inspector API was returning an error Inspected frame has gone. This was due to our keepAlive RemoteAgent function call trying to call to a page(frame?) that no longer exists. I've updated RemoteAgent to stop the keepAlive timer when a new page loads.
  • After getting in the above error state where the inspector web socket is still open, there were async issues calling Inspector.connect() where the inspector may get a disconnect event in the middle of the connection process. This caused an error dialog to appear Unable to load live development page. I've changed connect() to wait for a new disconnect() promise to complete.
    Slow page reload (5s) if the main editor does not show the main file #3792 After switching the current live document, remove all HTTP request filters.

@ghost ghost assigned redmunds May 20, 2013
@jasonsanjose
Copy link
Member Author

@redmunds ready to review again. I wasn't able to produce those console errors you saw from #3852. Could that be coming from an extension? The console log you pasted contains code that I couldn't find in Brackets core at all.

@redmunds
Copy link
Contributor

This looks good. I cannot reproduce the exceptions, so not sure where they were coming from. Travis build failed, so I'll merge when that's resolved.

@jasonsanjose
Copy link
Member Author

Hmm. @dangoor mentioned spurious jasmine-node errors earlier today. I can't reproduce these on my mac. Kevin, do you see any issues here? I think it's ok to merge.

@redmunds
Copy link
Contributor

Merging.

redmunds added a commit that referenced this pull request May 21, 2013
Fix live preview refresh issues (again)
@redmunds redmunds merged commit 3605a24 into master May 21, 2013
@redmunds redmunds deleted the jasonsanjose/issue-3792-again branch May 21, 2013 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants