Spanish strings for sprint 24 #3536
Conversation
|
Thanks @jbalsas. Can you find someone to do a peer review? |
|
Maybe @TomMalbran could take a look at it ;) I'll look for someone else otherwise. |
|
Sure, I can review it. |
| --> | ||
| <p> | ||
| <em>Brackets es un editor diferente.</em> | ||
| La gran diferencia es que está escrito en JavaScript, HTML y CSS. Esto significa que la mayoría de gente |
There was a problem hiding this comment.
Replace "gente" with "ustedes" or "vosotros" and in the next line "tiene" -> "tienen"
There was a problem hiding this comment.
I don't really like interjecting the reader here like that... what about "la mayoría de quienes usan Brackets..." ?
|
Review done. Notice that you are missing the Open line commands that were added after this pull request, although those aren't really important. One more thing. It bothers me a bit that the Menus get really wide in Spanish. I know that happens because we usually use longer words, phrases, but could you change "Control" to "Ctrl" and "Mayúsculas" to "May" or back to "Shift"? |
| "EXTENSION_INSTALLED" : "Instalada", | ||
| "EXTENSION_SEARCH_PLACEHOLDER" : "Buscar", | ||
| "EXTENSION_MORE_INFO_LINK" : "Más", | ||
| "EXTENSION_FREE_ON_GITHUB" : "¿Estás buscando interesantes novedades desarrolladas por la comunidad? Echa un vistazo a todas las extensiones gratis para Brackets en Github.", |
There was a problem hiding this comment.
This string was recently removed and a new one was added: BROWSE_EXTENSIONS" : "Browse Extensions".
|
@TomMalbran I've addressed all your concerns and pushed the fixes. For the couple of places where I suggested a different change I've gone with mine, so that you can just merge if you agree with them. Otherwise, we can discuss them longer. |
| </p> | ||
|
|
||
| <samp> | ||
| ¿Quieres verlo funcionando? Coloca tu cursor sobe la etiqueta <!-- <samp> --> superior y pulsa |
There was a problem hiding this comment.
"superior" could be removed or replaced with "arriba de esta línea" or similar mentioning the position better. But doesn't seem required, so just removing it would be fine.
|
@jbalsas Thanks for all the changes and your suggestions were fine too, but I found a few other strings that could be improved, sorry for not adding them in the first review. |
|
There is a new About dialog line that just landed and will need a translation. |
|
Hey folks--thanks for all the work on this. We're hoping to roll the final build for this sprint on Friday afternoon (Pacific time), so if you guys could finish this up and merge it by then that would be awesome. Thanks! |
|
@TomMalbran I've added your latest suggestions and translated the new "about" string. I've also noticed #3624, so I've added those as well, just in case. And please, don't worry about making me work, that's what these reviews are exactly for. Actually, I find translating to be very challenging, keeping in mind that spanish across countries can differ greatly. I really appreciate your input on this! @njx rest easy, we'll get this in by then ;) |
| @@ -286,7 +292,7 @@ define({ | |||
| "ABOUT_TEXT_LINE4" : "Puedes encontrar la documentación y código fuente en <a class=\"clickable-link\" data-href=\"https://github.com/adobe/brackets/\">https://github.com/adobe/brackets/</a>", | |||
| "ABOUT_TEXT_LINE5" : "Hecho con \u2764 y JavaScript por:", | |||
| "ABOUT_TEXT_LINE6" : "Mucha gente (pero ahora mismo estamos teniendo problemas para cargar esos datos).", | |||
| "UPDATE_NOTIFICATION_TOOLTIP" : "¡Hay una nueva versión de {APP_NAME} disponible! Haz click aquí para más detalles.", | |||
There was a problem hiding this comment.
Why are you removing this string? I haven't seen any changes about this line yet, but maybe I missed one of the latest update that wasn't merged yet.
There was a problem hiding this comment.
Oh, man... butter fingers I guess. I'll re-add this one.
|
@jbalsas Thanks for all the changes. The Getting Started content looks great. I have just 2 last comments, where the first one is the really important one, and we should be done, if the strings don't change again. I did found several strings hard to translate, specially when you can't say the same things in so few words or in the exact same way as in English. |
|
@TomMalbran Hopefully we're good to go now ;) |
|
Great. Merging it :) |
Spanish strings for sprint 24
Spanish strings, and Getting Started updates for sprint 24