[CLOSED] Spanish strings for sprint 24

[core-ai-bot]

Issue by jbalsas
Monday Apr 22, 2013 at 21:31 GMT
Originally opened as adobe/brackets#3536

---

Spanish strings, and Getting Started updates for sprint 24

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/3536/commits

[core-ai-bot]

Comment by jasonsanjose
Monday Apr 22, 2013 at 21:36 GMT

---

Thanks@jbalsas. Can you find someone to do a peer review?

[core-ai-bot]

Comment by jbalsas
Monday Apr 22, 2013 at 22:03 GMT

---

Maybe@TomMalbran could take a look at it ;) I'll look for someone else otherwise.

[core-ai-bot]

Comment by TomMalbran
Tuesday Apr 23, 2013 at 01:13 GMT

---

Sure, I can review it.

[core-ai-bot]

Comment by TomMalbran
Tuesday Apr 23, 2013 at 23:41 GMT

---

Review done.

Notice that you are missing the Open line commands that were added after this pull request, although those aren't really important.

One more thing. It bothers me a bit that the Menus get really wide in Spanish. I know that happens because we usually use longer words, phrases, but could you change "Control" to "Ctrl" and "Mayúsculas" to "May" or back to "Shift"?

[core-ai-bot]

Comment by jbalsas
Wednesday Apr 24, 2013 at 18:38 GMT

---

@TomMalbran I've addressed all your concerns and pushed the fixes. For the couple of places where I suggested a different change I've gone with mine, so that you can just merge if you agree with them. Otherwise, we can discuss them longer.

[core-ai-bot]

Comment by TomMalbran
Wednesday Apr 24, 2013 at 22:22 GMT

---

@jbalsas Thanks for all the changes and your suggestions were fine too, but I found a few other strings that could be improved, sorry for not adding them in the first review.

[core-ai-bot]

Comment by TomMalbran
Wednesday Apr 24, 2013 at 22:42 GMT

---

There is a new About dialog line that just landed and will need a translation.

[core-ai-bot]

Comment by njx
Thursday Apr 25, 2013 at 17:35 GMT

---

Hey folks--thanks for all the work on this. We're hoping to roll the final build for this sprint on Friday afternoon (Pacific time), so if you guys could finish this up and merge it by then that would be awesome. Thanks!

[core-ai-bot]

Comment by jbalsas
Thursday Apr 25, 2013 at 18:45 GMT

---

@TomMalbran I've added your latest suggestions and translated the new "about" string. I've also noticed #3624, so I've added those as well, just in case. And please, don't worry about making me work, that's what these reviews are exactly for. Actually, I find translating to be very challenging, keeping in mind that spanish across countries can differ greatly. I really appreciate your input on this!

@njx rest easy, we'll get this in by then ;)

[core-ai-bot]

Comment by TomMalbran
Thursday Apr 25, 2013 at 20:47 GMT

---

@jbalsas Thanks for all the changes. The Getting Started content looks great. I have just 2 last comments, where the first one is the really important one, and we should be done, if the strings don't change again.

I did found several strings hard to translate, specially when you can't say the same things in so few words or in the exact same way as in English.

[core-ai-bot]

Comment by jbalsas
Thursday Apr 25, 2013 at 21:18 GMT

---

@TomMalbran Hopefully we're good to go now ;)

[core-ai-bot]

Comment by TomMalbran
Thursday Apr 25, 2013 at 22:05 GMT

---

Great. Merging it :)