Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fixed reload problem for extensions #1555

Merged
merged 2 commits into from
Sep 5, 2012
Merged

Fixed reload problem for extensions #1555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e158ae9
Fixed reload problem for extensions
Sep 5, 2012
3471743
Added a comment to explain nocaching
Sep 5, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/utils/ExtensionLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ define(function (require, exports, module) {
extensionRequire = brackets.libRequire.config({
context: name,
baseUrl: config.baseUrl,
// Force extensions to not be cached by passing a unique value (time) as a URL argument
urlArgs: "nocache=" + (new Date()).getTime(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please add a comment to the code to explain what this does. When I saw a param called "nocache", I was expecting you could just use "nocache=true", so please explain why a unique value is required.

/* FIXME (issue #1087): can we pass this from the global require context instead of hardcoding twice? */
paths: globalConfig,
locale: window.localStorage.getItem("locale") || brackets.app.language
Expand Down