This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed reload problem for extensions #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing |
| @@ -68,6 +68,7 @@ define(function (require, exports, module) { | |||
| extensionRequire = brackets.libRequire.config({ | |||
| context: name, | |||
| baseUrl: config.baseUrl, | |||
| urlArgs: "nocache=" + (new Date()).getTime(), | |||
There was a problem hiding this comment.
This looks good. Please add a comment to the code to explain what this does. When I saw a param called "nocache", I was expecting you could just use "nocache=true", so please explain why a unique value is required.
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Sep 5, 2012
Fixed reload problem for extensions
redmunds
added a commit
that referenced
this pull request
Sep 6, 2012
revert pull #1555 (Fixed reload problem for extensions) -- using nocache causes problems with breakpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1551 but extensions will never be cached. Not sure if there are any real world performance implications, but it could be made optional on build versions.