This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Input fields don't work in dialogs #1243
Assignees
Comments
Merged
peterflynn
added a commit
that referenced
this issue
Aug 1, 2012
Fix for issue #1243 (Input fields don't work in dialogs)
|
Confirmed fixed as part of pull request review |
|
Tagging Sprint 12 so we remember when it was fixed |
|
Reopening -- I just discovered that key handling still prevents you from putting useful text fields in dialogs, since some keys are interpreted as dialog-closing shortcuts. For example, in the text dialog above try typing the letter "n" on Windows... |
peterflynn
added a commit
that referenced
this issue
Sep 27, 2012
…rlier fix that let keystrokes through to the textfield, but auto-closed the dialog when certain chars were typed. Now we only close the dialog if the char typed could not have been intended as text input.
RaymondLim
added a commit
that referenced
this issue
Sep 27, 2012
Fix bug #1243 (Input fields don't work in dialogs)
|
Updated fix has been merged -- closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Dialogs.showModalDialog(Dialogs.DIALOG_ID_ERROR, "Test", "<input type='text' />");Result: Field gets focused, but keystrokes do nothing
There's code in
Dialogs._handleKeyDown()that attempts to let input elements work, but it looks wrong. Instead ofthis.filter(":input")it should probably be something like$(e.target).filter(":input").The text was updated successfully, but these errors were encountered: