[CLOSED] Input fields don't work in dialogs

[core-ai-bot]

Issue by peterflynn
Thursday Jul 12, 2012 at 21:41 GMT
Originally opened as adobe/brackets#1243

---

1. Run this code somewhere in Brackets: Dialogs.showModalDialog(Dialogs.DIALOG_ID_ERROR, "Test", "<input type='text' />");
2. Try to type in the input field that appears in the dialog

Result: Field gets focused, but keystrokes do nothing

There's code in Dialogs._handleKeyDown() that attempts to let input elements work, but it looks wrong. Instead of this.filter(":input") it should probably be something like $(e.target).filter(":input").

[core-ai-bot]

Comment by peterflynn
Wednesday Aug 01, 2012 at 22:09 GMT

---

Confirmed fixed as part of pull request review

[core-ai-bot]

Comment by peterflynn
Wednesday Aug 08, 2012 at 17:25 GMT

---

Tagging Sprint 12 so we remember when it was fixed

[core-ai-bot]

Comment by peterflynn
Thursday Sep 27, 2012 at 01:20 GMT

---

Reopening -- I just discovered that key handling still prevents you from putting useful text fields in dialogs, since some keys are interpreted as dialog-closing shortcuts. For example, in the text dialog above try typing the letter "n" on Windows...

[core-ai-bot]

Comment by peterflynn
Thursday Sep 27, 2012 at 22:45 GMT

---

Updated fix has been merged -- closing