Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First - this PR relies/assumes on #49 being merged - so that update is already here in this PR. Due to the number of updates in the pom, if i went back to the baseline
main
branch, there would be a number of conflicts. I assume there will be discussion on this PR, so I'll rebase after the other is merged. Now, details:This PR is based on a few assumptions and expectations of following OSGi best practices, as follows:
Jackson should not be exported from the shared library.
The use of Feign is an implementation detail of the embedded Jars. It should not be exported from the libraries and exposed to the OSGi context
There is still one OSGI warning that I cannot remove and will likely cause issues:
The Shared Library is exporting the Adobe XDM Event common library. This has one class
XDMEvent
that relies on theNotNull
constraint. This a Runtime retained annotation, and therefore the classloader/classpath needs it at runtime to perform correct processing. As far as I can tell, this package does not exist in OSGi/Sling/AEM OOTB. And given it's context, I don't think it's appropriate to export it.I honestly have no idea if this will or won't cause issues when the XDMEvent is used in the AEM classpath.