Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow OSGi best practice #59

Closed
francoisledroff opened this issue Mar 21, 2022 · 1 comment
Closed

follow OSGi best practice #59

francoisledroff opened this issue Mar 21, 2022 · 1 comment

Comments

@francoisledroff
Copy link
Collaborator

among these

  1. Jackson should not be exported from the shared library.
    • This needs to be provided by the container
    • AEM Provides v2.9 w/ 6.5.0; the Manifest was configured to bind to this version up to, but not including, 3.0.
  2. The use of Feign is an implementation detail of the embedded Jars. It should not be exported from the libraries and exposed to the OSGi context
@francoisledroff
Copy link
Collaborator Author

see #58

francoisledroff added a commit to francoisledroff/aio-lib-java that referenced this issue Mar 21, 2022
@francoisledroff
adobeGH-59 a few fixes/polishing on top of Bryan PR
4cae89b 
* Fixing the missing workspace in a few places
* updated a few README files
* Fixed the service user config
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
Merge pull request #60 from francoisledroff/GH-59
bab4907 
GH-59 : following osgi best practices
francoisledroff added a commit to francoisledroff/aio-lib-java that referenced this issue Mar 21, 2022
@francoisledroff
adobeGH-59 attempt to fix the mvn release process launching the javad…
554103c 
…oc plugin
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
Merge pull request #61 from adobe/GH-59
92ad6bd 
GH-59 attempt to fix the mvn release process launching the javadoc plugin
francoisledroff added a commit to francoisledroff/aio-lib-java that referenced this issue Mar 21, 2022
@francoisledroff
adobeGH-59 fixing version to snapshot after failed released through g…
e8bb025 
…h actions
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
Merge pull request #62 from francoisledroff/GH-59
60f2bbb 
GH-59 fixing version to snapshot after failed released through gh actions
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
GH-59 removing javadoc from relese
bf4784e
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
GH-59 removing javadoc from release
cc3b16e
francoisledroff added a commit that referenced this issue Mar 21, 2022
@francoisledroff
GH-59 removing javadoc from release
62eb3a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@francoisledroff