Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 Support #166

Merged
merged 35 commits into from
Aug 24, 2023
Merged

OAuth2 Support #166

merged 35 commits into from
Aug 24, 2023

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Aug 17, 2023 •
edited by francoisledroff
Loading

Description

Update API to support OAuth Server-to-Server client credentials approach to Authentication.

Related Issue

Motivation and Context

Updates library to prepare for removal of deprecated JWT solution.

How Has This Been Tested?

Update existing unit tests, and added new ones.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

bstopp added 23 commits August 3, 2023 10:47
@bstopp
Update Copyright year.
be78141
@bstopp
Use JUnit Jupiter
cc1b8a0
@bstopp
Add Mockito and some tests.
3317b6a
@bstopp
Upgrade to JUnit Jupiter.
3130660
@bstopp
Extract JWT context/credentials
236d5dc
@bstopp
Add OAuthContext support.
56974cb
@bstopp
Move test utilty to test folder.
ce631a1
@bstopp
Use mockserver for validating API calls.
fedb0e0
@bstopp
Add test cases and modify under-the-hood for JWT deprecation.
70c94b7
@bstopp
Add OAuth API.
2f34fb5
@bstopp
Some clean up.
af95cf5
@bstopp
Add test cases for JWT Interceptor.
80385c5
@bstopp
Update to JUnit Jupiter.
bf71392
@bstopp
Update to JUnit Jupiter.
b9a2de2
@bstopp
Update to JUnit Jupiter & move away from mocking server calls
3c234f8
@bstopp
Build test jar for WorkflowUtil
4bc67b2
@bstopp
Remove network requirement for tests.
5d1e40a
@bstopp
update to JUnit Jupiter, and use test library.
284c3ae
@bstopp
Fix Pom order.
2f374b8
@bstopp
Upgrade to JUnit Jupiter
310a982
@bstopp
Need Java8 support.
9508b84 
Remove JUnit from modules without tests.
@bstopp
Bring versions up-to-date
81a0780
@bstopp
Update all plugins.
af8d525
@bstopp bstopp changed the title Feat/oauth2 WIP OAuth@ Support Aug 17, 2023
@bstopp bstopp mentioned this pull request Aug 17, 2023
Closed
9 tasks
@bstopp bstopp changed the title WIP OAuth@ Support WIP OAuth2 Support Aug 17, 2023
@bstopp bstopp requested a review from francoisledroff August 17, 2023 15:36
@bstopp bstopp temporarily deployed to aio_prod August 21, 2023 15:10 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_stage August 21, 2023 15:10 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_prod August 21, 2023 15:37 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_stage August 21, 2023 15:37 — with GitHub Actions Inactive
@bstopp bstopp marked this pull request as draft August 21, 2023 19:58
@bstopp bstopp temporarily deployed to aio_prod August 21, 2023 22:30 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_stage August 21, 2023 22:30 — with GitHub Actions Inactive
@bstopp bstopp marked this pull request as ready for review August 21, 2023 22:56
@bstopp
Copy link
Collaborator Author

bstopp commented Aug 21, 2023

Ok, now it should be good to go.

@francoisledroff
Some proposal for better Backward compatibility (#167)
1b3ea47 
* re-introducing `Workspace.getCredentialId()`
* moving back `WorkspaceUtil` to  `com.adobe.aio.util`
@bstopp bstopp temporarily deployed to aio_prod August 22, 2023 15:27 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_prod August 22, 2023 15:45 — with GitHub Actions Inactive
francoisledroff
francoisledroff approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@francoisledroff francoisledroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.
Thanks again for the PR Bryan !

@bstopp bstopp temporarily deployed to aio_prod August 22, 2023 16:25 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_stage August 22, 2023 16:25 — with GitHub Actions Inactive
@rperelma
Copy link

@francoisledroff will you merge it?

This was linked to issues Aug 22, 2023
aem aio-aem-events-publish: Service Account (JWT) DEPRECATED #155
Closed
ims add a new OAuth2 Server-to-Server Request Interceptor #163
Closed
@francoisledroff
Let's stick to the old CloudEvents v1 spec and package for now (#168)
f98e8ed 
as we did not test the latest package and as this format is key to our partners integration
@bstopp bstopp temporarily deployed to aio_stage August 23, 2023 14:50 — with GitHub Actions Inactive
@bstopp bstopp temporarily deployed to aio_prod August 23, 2023 14:50 — with GitHub Actions Inactive
@francoisledroff francoisledroff merged commit a7dc7bf into main Aug 24, 2023
This was referenced Aug 24, 2023
Closed
Closed
@bstopp bstopp deleted the feat/oauth2 branch August 24, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisledroff francoisledroff francoisledroff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bstopp @francoisledroff @rperelma