Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP OAuth2 Support #165

Closed
wants to merge 23 commits into from
Closed

WIP OAuth2 Support #165

wants to merge 23 commits into from

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Aug 7, 2023

Description

Update API to support OAuth Server-to-Server client credentials approach to Authentication.

Related Issue

#155

Motivation and Context

Updates library to prepare for removal of deprecated JWT solution.

How Has This Been Tested?

Update existing unit tests, and added new ones.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bstopp bstopp changed the title OAuth2 Support WIP OAuth2 Support Aug 7, 2023
@rperelma
Copy link

rperelma commented Aug 7, 2023

Wow, thank you @bstopp !!! @francoisledroff is out this week, but will review when he is back.

@bstopp
Copy link
Collaborator Author

bstopp commented Aug 16, 2023

@francoisledroff - I don't know why the integration tests are failing. Its saying NPE, which indicates it can't find the fallback properties file. The actions should have all the necessary properties defined to successfully run these checks.

I don't have the information necessary to run the IT tests offline. I'm not sure if this is something you can do, to check the updates and make sure it wasn't something i introduced?

@bstopp
Copy link
Collaborator Author

bstopp commented Aug 16, 2023

I went ahead and updated all the plugins and dependencies to latest releases.

I'll be going back and adding more tests over the next couple of days while folks find time to review.

@francoisledroff
Copy link
Collaborator

@bstopp the IT tests are leveraging GH secrets only available on the main remote repo.
If you push your change against a remote branch and update your PR accordingly,
the IT test should run (using the deprecated JWT authentication)

@bstopp
Copy link
Collaborator Author

bstopp commented Aug 17, 2023

Closing this in favor of #166

@bstopp bstopp closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants