Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-21 and GH-104 jdk8 support and move of the xdm IO Events Model here as a new module #130

Merged
merged 14 commits into from
Nov 24, 2022
Merged

GH-21 and GH-104 jdk8 support and move of the xdm IO Events Model here as a new module #130

merged 14 commits into from
Nov 24, 2022

Conversation

francoisledroff
Copy link
Collaborator

@francoisledroff francoisledroff commented Nov 22, 2022 •
edited
Loading

Description

  • downgrading the java compiler's source and target to support jdk8 users
  • the XDM Adobe I/O Events Model has find here a new home and a new name
    • relocating com.adobe.event:xdm-event-model as a new module of this repo
    • renaming it to com.adobe.aio:aio-lib-java-events-xdm
  • other minor updates:
    • aligning with the relocation of The artifact junit:junit-dep:jar:4.11 to junit:junit:jar:4.11
    • polishing: adding a few README.md details
    • fixing typo

Related Issue

pulguptaAdobe and others added 11 commits October 26, 2022 17:42
@francoisledroff francoisledroff temporarily deployed to aio_stage November 22, 2022 15:40 Inactive
@francoisledroff francoisledroff mentioned this pull request Nov 22, 2022
Merged
8 tasks
@francoisledroff francoisledroff temporarily deployed to aio_stage November 22, 2022 15:52 Inactive
@francoisledroff francoisledroff temporarily deployed to aio_prod November 22, 2022 15:52 Inactive
@francoisledroff francoisledroff temporarily deployed to aio_prod November 22, 2022 17:07 Inactive
@francoisledroff francoisledroff temporarily deployed to aio_stage November 22, 2022 17:07 Inactive
@francoisledroff francoisledroff temporarily deployed to aio_prod November 22, 2022 17:13 Inactive
@francoisledroff francoisledroff temporarily deployed to aio_stage November 22, 2022 17:13 Inactive
This was referenced Nov 22, 2022
Closed
Closed
sangeetha5491
sangeetha5491 requested changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@sangeetha5491 sangeetha5491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment. the changes look good.

events_xdm/src/main/java/com/adobe/xdm/common/XdmEvent.java
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonProperty;

@JsonIgnoreProperties(ignoreUnknown = true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @JsonInclude(Include.NON_NULL)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this on purpose to avoid adding yet another dependency

@francoisledroff francoisledroff merged commit 5980e93 into main Nov 24, 2022
@francoisledroff francoisledroff deleted the java8 branch December 14, 2022 10:37
@francoisledroff francoisledroff mentioned this pull request Jan 31, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangeetha5491 sangeetha5491 sangeetha5491 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francoisledroff @sangeetha5491 @pulguptaAdobe