-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-125 add new webhook module for payload authentication #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofit and unwanted dependecies
pulling changes of my own branch
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Outdated
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Outdated
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Outdated
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Outdated
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Outdated
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Show resolved
Hide resolved
events_webhook/src/main/java/com/adobe/aio/event/webhook/service/EventVerifier.java
Show resolved
Hide resolved
events_webhook/src/test/java/com/adobe/aio/event/webhook/service/EventVerifierTest.java
Outdated
Show resolved
Hide resolved
@francoisledroff : please review |
@francoisledroff : please review |
@francoisledroff : could you please review |
francoisledroff
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds new module events_webhook which has the
Related Issue
created on top of the changes in this #125
Motivation and Context
Helps I/O Events Customers to setup their webhook verification using this sdk feature.
How Has This Been Tested?
Has the test
EventVerifierTest
which tests the api for verifying signature.Screenshots (if appropriate):
Types of changes
Checklist: