Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-125 add new webhook module for payload authentication #144

Merged
merged 33 commits into from
Feb 7, 2023

Conversation

abhupadh
Copy link
Collaborator

@abhupadh abhupadh commented Jan 31, 2023

Description

adds new module events_webhook which has the

  • payload recipient verification
  • I/O Events webhook signature verification method

Related Issue

created on top of the changes in this #125

Motivation and Context

Helps I/O Events Customers to setup their webhook verification using this sdk feature.

How Has This Been Tested?

Has the test EventVerifierTest which tests the api for verifying signature.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@abhupadh abhupadh temporarily deployed to aio_prod January 31, 2023 20:49 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod January 31, 2023 20:54 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod February 2, 2023 02:08 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod February 2, 2023 20:55 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_stage February 2, 2023 20:55 — with GitHub Actions Inactive
@abhupadh
Copy link
Collaborator Author

abhupadh commented Feb 2, 2023

@francoisledroff : please review

@abhupadh abhupadh temporarily deployed to aio_prod February 3, 2023 19:16 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_stage February 3, 2023 19:16 — with GitHub Actions Inactive
@abhupadh
Copy link
Collaborator Author

abhupadh commented Feb 3, 2023

@francoisledroff : please review

@abhupadh
Copy link
Collaborator Author

abhupadh commented Feb 6, 2023

@francoisledroff : could you please review

@abhupadh abhupadh temporarily deployed to aio_stage February 6, 2023 22:13 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod February 6, 2023 22:13 — with GitHub Actions Inactive
Copy link
Collaborator

@francoisledroff francoisledroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants