Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync dev to main before release #329

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Sync dev to main before release #329

merged 7 commits into from
Jun 28, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jun 28, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

LSantha and others added 7 commits December 11, 2023 17:34
 * updated to CIF components 2.12.4
SITES-17835 - Release CIF Components 2.12.4
SITES-19186 - Release CIF Components 2.12.6
* fix ui & integration tests
* improved unit test coverage
* updated dependencies to CIF Components 2.13.0
…y of errors (#328)

* adds filters for commerce api issues
* resolves the sling attribute issue
* fixed error checking conditions,
* updates/add unit testcases
* resolves the build issues
* fixed POM dependencies to fix the build failure
* resolves the integration test issues
* resolves the searchresult issue
* resolves the placeholder inetgration tests
* adds unit test coverage for commercecomponentModelfinder
* adds unit test coverage for catalogpageexceptionfilter
* undo IT test data changes
* resolves the pr comments
* removes unwanted import & spaces
* fixed page title
---------
Co-authored-by: levente <levente@adobe.com>
@LSantha LSantha requested a review from alwinjoseph02 June 28, 2024 08:46
Copy link
Collaborator

@alwinjoseph02 alwinjoseph02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Approved!

@LSantha LSantha merged commit 5404a15 into main Jun 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants